Don't clear out resolutions from the votestore if the DB is restored … #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88b2ca7 to
61bf1e6
Compare
c0efbc2 to
b5f16d3
Compare
…using a statesync snapshot
b5f16d3 to
59c58b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…using a statesync snapshot
If the DB is restored from genesis snapshots during offline or ZDT migrations, the resolutions from the voting table should be cleared out especially the validator and migration resolutions as they are not applicable for the new network. However this should not be done for the statesync snapshots. (This is a regression from the changes I made yesterday)
This PR also adds a new integration test to test out unresolved resolutions in statesync snapshots
Also fixes incomplete statesync tests