fixup example.sh like 2.3.0 main.sh #87
Conversation
__i_am_main_script logic fixed for example.sh added double-sourced test
78943ef to
d879ae1
Compare
|
@mstreuhofer if you're finished, I propose I rebase #86 right onto this PR. What are your thoughts? |
@mstreuhofer Can I just add my commits to this PR? Because I think I have a fix for the MacOS build failures.... then we can just close one PR... I know @kvz is off enjoying his weekend already, and I don't see any reason why anyone would object to your proposed changes |
test/fixture/main-nocolor.stdio
Outdated
| @@ -5,7 +5,6 @@ ACCPTST:STDIO_REPLACE_DATETIMES | |||
| {datetime} UTC [ info] __dir: {root} | |||
| {datetime} UTC [ info] __base: main | |||
| {datetime} UTC [ info] OSTYPE: {OSTYPE} | |||
| {datetime} UTC [ info] Script called directly? yes | |||
There was a problem hiding this comment.
Thanks, sorry I missed that
There was a problem hiding this comment.
np. now let's see what the tests are saying once they are done.
There was a problem hiding this comment.
I think I may need to move lanyon to dev dependency
There was a problem hiding this comment.
it looks like yarn is still broken, and without mentioning lanyon explicitly in package.json npm ... fails epically... I put it in plain old dependencies, but it looks like @kvz puts them in dev dependencies... yarnpkg/yarn#760 is still unresolved, it appears
|
I'm going to make this change and then cancel the jobs, except for the latest push and pr job |
|
ok. i'll stay clear until the dust settled. |
|
hmmmm I think 9c747d2 is not the fix... it's already listed in the dev dependencies... The issue may be that lanyon requires bundler which may be missing on OS X.... and of course the OS X CI queues are super backed up as always. |
2eacc26 to
d879ae1
Compare
Update acceptance tests
`npm run start` didn't work for me... I had to get yarn and do `yarn install` first. I'm guessing this will be true for others.
Add tests to help catch bash4-isms and ensure syntax is checked with all bashes on PATH in a given system.
390e542 to
cb29b2f
Compare
|
Trying @zbeekman! With a bunch of commits to master - for which I'm sorry, but I don't have a better way of debugging things on Travis that pass locally. (setting up a Travis VM locally is a bit beyond what I can invest atm). |
|
Okay should be good @mstreuhofer @zbeekman (meaning: it's failing on this now: https://travis-ci.org/kvz/bash3boilerplate/jobs/201536450#L2779) - sorry for the delay! |
|
thanks @kvz! Looking good. Not sure what that build failure was about, but the problem seems to have gone away... probably you were on a stale branch? |
|
I think this very PR addressed it(?) my stuff was in master
On Tue, 14 Feb 2017 at 19:02, Izaak Beekman ***@***.***> wrote:
thanks @kvz <https://github.com/kvz>! Looking good. Not sure what that
build failure was about, but the problem seems to have gone away...
probably you were on a stale branch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATIcHDCze7_k3duZNMbacQs9b2SPtOoMks5rcewjgaJpZM4L9xew>
.
--
Sent from mobile, pardon the brevity.
|
__i_am_main_script logic fixed for example.sh
added double-sourced test