Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unneeded regex sub (fixes #41) #42

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

domdepasquale
Copy link
Contributor

No description provided.

the yq action is expected to be used via `with:` configuration.

The yq we use in kustomize-build is actually on the github runner itself
@pusher-robot
Copy link

Comparison of deploy-pr/env-dev 17629a to proposed changes to env/dev in this PR

Diff output
diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
similarity index 97%
rename from Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
rename to Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
index ef2a603..0486c60 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.9048452017.2
+        - image: nginx:1.9105227637.0
           name: nginx
           ports:
             - containerPort: 80

@pusher-robot
Copy link

Comparison of deploy-pr/env-dev 17629a to proposed changes to env/dev in this PR

Diff output
diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
similarity index 97%
rename from Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
rename to Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
index ef2a603..5f9af6a 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.9048452017.2
+        - image: nginx:1.9105227637.1
           name: nginx
           ports:
             - containerPort: 80

@pusher-robot
Copy link

Comparison of deploy-pr/env-dev 17629a to proposed changes to env/dev in this PR

Diff output
diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
similarity index 96%
rename from Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
rename to Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
index ef2a603..1808dcf 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.9048452017.2
+        - image: nginx:1.91052276372.0
           name: nginx
           ports:
             - containerPort: 80

@pusher-robot
Copy link

Comparison of deploy-pr/env-dev 17629a to proposed changes to env/dev in this PR

Diff output
diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
similarity index 97%
rename from Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
rename to Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
index ef2a603..9385e69 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.9048452017.2
+        - image: nginx:1.9105227637.2
           name: nginx
           ports:
             - containerPort: 80

@navneet-bairwal navneet-bairwal merged commit 67457ce into main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants