Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth0のDatabase Connections対応 #32

Merged
merged 2 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Controller/Auth0Controller.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@

use Eccube\Controller\AbstractController;
use KnpU\OAuth2ClientBundle\Client\ClientRegistry;
use KnpU\OAuth2ClientBundle\Security\Helper\FinishRegistrationBehavior;
use Plugin\Auth0\Repository\ConfigRepository;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\Annotation\Route;

Expand All @@ -25,6 +29,8 @@
*/
class Auth0Controller extends AbstractController
{
use FinishRegistrationBehavior;

/**
* @param ClientRegistry $clientRegistry
* @param ConfigRepository $configRepository
Expand Down Expand Up @@ -55,4 +61,20 @@ public function connect(ClientRegistry $clientRegistry, ConfigRepository $config
public function callback()
{
}

/**
* @param Request $request
* @return Response
*
* @Route("/connect/email_veridied", name="auth0_connect_email_verified")
*/
public function emailVerified(Request $request): Response
{
$userInfo = $this->getUserInfoFromSession($request);
if (!$userInfo) {
throw new BadRequestHttpException();
}

return new Response(trans('plugin.social_login.front.email_verified'));
}
}
2 changes: 1 addition & 1 deletion Nav.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static function getNav(): array
'customer' => [
'children' => [
'auth0_config' => [
'name' => 'plguin.social_login.admin.setting.title',
'name' => 'plugin.social_login.admin.setting.title',
'url' => 'social_login_admin_config',
],
],
Expand Down
25 changes: 19 additions & 6 deletions Resource/locale/messages.ja.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
plguin.social_login.admin.config.title: 'ソーシャルログイン'
plguin.social_login.admin.config.sub_title: '設定'
plguin.social_login.admin.setting.title: 'Auth0設定'
plguin.social_login.admin.client_id.label: 'Client ID'
plguin.social_login.admin.client_secret.label: 'Client Secret'
plguin.social_login.admin.custom_domain.label: 'Domain'
plugin:
social_login:
admin:
config:
title: 'ソーシャルログイン'
sub_title: '設定'
setting:
title: 'Auth0設定'
client_id:
label: 'Client ID'
client_secret:
label: 'Client Secret'
custom_domain:
label: 'Domain'

front:
email_verified: 'メールを送信しました。アカウントを認証してください。'


8 changes: 4 additions & 4 deletions Resource/template/admin/config.twig
Original file line number Diff line number Diff line change
Expand Up @@ -20,26 +20,26 @@
<div class="c-contentsArea__primaryCol">
<div class="c-primaryCol">
<div class="card rounded border-0 mb-4">
<div class="card-header"><span>{{ 'plguin.social_login.admin.setting.title'|trans }}</span></div>
<div class="card-header"><span>{{ 'plugin.social_login.admin.setting.title'|trans }}</span></div>
<div class="card-body">
<div class="row">
<div class="col-3"><span>{{ 'plguin.social_login.admin.client_id.label'|trans }}</span><span
<div class="col-3"><span>{{ 'plugin.social_login.admin.client_id.label'|trans }}</span><span
class="badge badge-primary ml-1">{{ 'admin.common.required'|trans }}</span></div>
<div class="col mb-2">
{{ form_widget(form.client_id) }}
{{ form_errors(form.client_id) }}
</div>
</div>
<div class="row">
<div class="col-3"><span>{{ 'plguin.social_login.admin.client_secret.label'|trans }}</span><span
<div class="col-3"><span>{{ 'plugin.social_login.admin.client_secret.label'|trans }}</span><span
class="badge badge-primary ml-1">{{ 'admin.common.required'|trans }}</span></div>
<div class="col mb-2">
{{ form_widget(form.client_secret) }}
{{ form_errors(form.client_secret) }}
</div>
</div>
<div class="row">
<div class="col-3"><span>{{ 'plguin.social_login.admin.custom_domain.label'|trans }}</span><span
<div class="col-3"><span>{{ 'plugin.social_login.admin.custom_domain.label'|trans }}</span><span
class="badge badge-primary ml-1">{{ 'admin.common.required'|trans }}</span></div>
<div class="col mb-2">
{{ form_widget(form.custom_domain) }}
Expand Down
28 changes: 18 additions & 10 deletions Security/Authenticator/Auth0Authenticator.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
use KnpU\OAuth2ClientBundle\Security\Authenticator\OAuth2Authenticator;
use KnpU\OAuth2ClientBundle\Security\Exception\FinishRegistrationException;
use Plugin\Auth0\Entity\Connection;
use Plugin\Auth0\Security\Exception\EmailVerifiedException;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
Expand Down Expand Up @@ -104,14 +105,15 @@ public function authenticate(Request $request): Passport
return new SelfValidatingPassport(
new UserBadge($accessToken->getToken(), function () use ($accessToken, $client) {
$user = $client->fetchUserFromToken($accessToken);
$user = $user->toArray();

if (!$user->toArray()['email_verified']) {
throw new AuthenticationException();
if (!$user['email_verified']) {
throw new EmailVerifiedException($user);
}

/** @var Connection $Connection */
$Connection = $this->entityManager->getRepository(Connection::class)
->findOneBy(['user_id' => $user->toArray()['sub']]);
->findOneBy(['user_id' => $user['sub']]);

// 連携済みの場合
if ($Connection) {
Expand All @@ -126,16 +128,16 @@ public function authenticate(Request $request): Passport

/** @var Customer $Customer */
$Customer = $this->entityManager->getRepository(Customer::class)
->findOneBy(['email' => $user->getEmail()]);
->findOneBy(['email' => $user['email']]);

// 会員登録していない場合、会員登録ページへ
if (null === $Customer) {
throw new FinishRegistrationException($user->toArray());
throw new FinishRegistrationException($user);
}

// 会員登録済みの場合はユーザー識別子を保存
$Connection = new Connection();
$Connection->setUserId($user->toArray()['sub']);
$Connection->setUserId($user['sub']);
$Connection->setCustomer($Customer);
$this->entityManager->persist($Connection);
$this->entityManager->flush();
Expand Down Expand Up @@ -167,14 +169,20 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token,
*/
public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
{
if ($exception instanceof EmailVerifiedException) {
$this->saveUserInfoToSession($request, $exception);

return new RedirectResponse($this->router->generate('auth0_connect_email_verified'));
}

if ($exception instanceof FinishRegistrationException) {
$this->saveUserInfoToSession($request, $exception);

return new RedirectResponse($this->router->generate('entry'));
} else {
$this->saveAuthenticationErrorToSession($request, $exception);

return new RedirectResponse($this->router->generate('mypage_login'));
}

$this->saveAuthenticationErrorToSession($request, $exception);

return new RedirectResponse($this->router->generate('mypage_login'));
}
}
24 changes: 24 additions & 0 deletions Security/Exception/EmailVerifiedException.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php

/*
* This file is part of Auth0 for EC-CUBE
*
* Copyright(c) Akira Kurozumi <info@a-zumi.net>
*
* https://a-zumi.net
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Plugin\Auth0\Security\Exception;

use KnpU\OAuth2ClientBundle\Security\Exception\FinishRegistrationException;

class EmailVerifiedException extends FinishRegistrationException
{
public function getMessageKey(): string
{
return 'You need to verify your email address.';
}
}
10 changes: 10 additions & 0 deletions Tests/Security/Authenticator/Auth0AuthenticatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use Eccube\Tests\EccubeTestCase;
use KnpU\OAuth2ClientBundle\Security\Exception\FinishRegistrationException;
use Plugin\Auth0\Security\Authenticator\Auth0Authenticator;
use Plugin\Auth0\Security\Exception\EmailVerifiedException;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Session\Session;
Expand Down Expand Up @@ -62,6 +63,15 @@ public function testStart()
self::assertTrue($response->isRedirect($this->router->generate('auth0_connect')));
}

public function testOnAuthenticationFailureEmailVerifiedException()
{
$request = new Request();
$request->setSession(new Session(new MockArraySessionStorage()));

$response = $this->authenticator->onAuthenticationFailure($request, new EmailVerifiedException([]));
self::assertTrue($response->isRedirect($this->router->generate('auth0_connect_email_verified')));
}

public function testOnAuthenticationFailureFinishRegistrationException()
{
$request = new Request();
Expand Down
7 changes: 7 additions & 0 deletions Tests/Web/Auth0ControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

use Eccube\Tests\Web\AbstractWebTestCase;
use Plugin\Auth0\Entity\Config;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

class Auth0ControllerTest extends AbstractWebTestCase
{
Expand Down Expand Up @@ -48,4 +49,10 @@ public function testAuth0の設定をしていたらリダイレクト()
$this->client->request('GET', $this->generateUrl('auth0_connect'));
self::assertTrue($this->client->getResponse()->isRedirect());
}

public function testUserInfoがない場合メールアドレス認証案内ページにアクセスできない()
{
$this->client->request('GET', $this->generateUrl('auth0_connect_email_verified'));
self::assertTrue($this->client->getResponse()->isClientError());
}
}