add controller scaffold #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preliminary-kurator canceled.
|
08923bb to
071ea69
Compare
zirain
reviewed
Nov 19, 2022
Makefile
Outdated
| @@ -152,3 +153,23 @@ gen-crd: init-codegen ## Generate WebhookConfiguration, ClusterRole and CustomRe | |||
| .PHONY: generate | |||
| generate: init-codegen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations. | |||
| hack/update-codegen.sh | |||
|
|
|||
| .PHONY: install-crd | |||
| install-crd: gen-crd ## Install CRDs into the K8s cluster specified in ~/.kube/config. | |||
There was a problem hiding this comment.
I do not think we need this; we use helm to install all stuffs
There was a problem hiding this comment.
ok，it has been removed
Makefile
Outdated
| install-crd: gen-crd ## Install CRDs into the K8s cluster specified in ~/.kube/config. | ||
| $(KUSTOMIZE) build manifests/charts | kubectl apply -f - | ||
|
|
||
| .PHONY: uninstall-crd |
Makefile
Outdated
| $(KUSTOMIZE) build manifests/charts | kubectl delete --ignore-not-found=$(ignore-not-found) -f - | ||
|
|
||
| .PHONY: run-controller | ||
| run-controller: gen-crd generate fmt vet ## Run a controller from your host. |
Makefile
Outdated
| go run ./cmd/controller/main.go | ||
|
|
||
| .PHONY: fmt | ||
| fmt: ## Run go fmt against code. |
Makefile
Outdated
| go fmt ./... | ||
|
|
||
| .PHONY: vet | ||
| vet: ## Run go vet against code. |
cmd/controller/main.go
Outdated
| @@ -0,0 +1,121 @@ | |||
| /* | |||
There was a problem hiding this comment.
should be part of cluster-operator
| @@ -71,7 +71,7 @@ type Machine struct { | |||
| HostName string `json:"hostName,omitempty"` | |||
| // PrivateIP is the private ip address of the machine: | |||
| // +optional | |||
| PrivateIP string `json:"publicIP,omitempty"` | |||
b308bcd to
197a279
Compare
zirain
reviewed
Nov 21, 2022
| limitations under the License. | ||
| */ | ||
|
|
||
| // code in the package copied from: https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/v1.5.1/main.go |
Signed-off-by: Xieql <xieqianglong@huawei.com>
fe2ee59 to
77653ec
Compare
hzxuzhonghu
reviewed
Nov 21, 2022
| @@ -71,7 +71,7 @@ type Machine struct { | |||
| HostName string `json:"hostName,omitempty"` | |||
| // PrivateIP is the private ip address of the machine: | |||
| // +optional | |||
| PrivateIP string `json:"publicIP,omitempty"` | |||
| @@ -0,0 +1,48 @@ | |||
| /* | |||
There was a problem hiding this comment.
CustomResources seems very general. how about customcluster.go
hzxuzhonghu
reviewed
Nov 21, 2022
| ) | ||
|
|
||
| // CustomClusterReconciler reconciles a CustomCluster object | ||
| type CustomClusterReconciler struct { |
There was a problem hiding this comment.
s/CustomClusterReconciler/CustomClusterController
Signed-off-by: Xieql <xieqianglong@huawei.com>
hzxuzhonghu
reviewed
Nov 21, 2022
| ) | ||
|
|
||
| // CustomMachineReconciler reconciles a CustomMachine object | ||
| type CustomMachineReconciler struct { |
There was a problem hiding this comment.
s/CustomMachineReconciler/CustomMachineController
|
I think we still lack the clusterrolem but can be in a follow up |
Signed-off-by: Xieql <xieqianglong@huawei.com>
hzxuzhonghu
approved these changes
Nov 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
part #96
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?