Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): upgrade envoy to v1.31 (#10942)" #11035

Merged

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Aug 2, 2024

This reverts commit 58a38d8.

Envoy 1.31.0 upgraded c-ares dependency from 1.19.1 to 1.20.1 which contains regression. This bug is breaking Kuma in ECS when data planes are connecting to the control plane using DNS name. It was fixed in Envoy, but patch was not released yet. Until Envoy 1.31.1 is released we have to downgrade to the last known working Envoy.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • No relevant issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md?
    • There is no need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • There is no need

Changelog: skip

This reverts commit 58a38d8.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner August 2, 2024 11:20
@bartsmykla bartsmykla requested review from slonka, jakubdyszkiewicz and michaelbeaumont and removed request for a team August 2, 2024 11:20
@bartsmykla bartsmykla enabled auto-merge (squash) August 2, 2024 11:34
@bartsmykla bartsmykla merged commit eea77a6 into kumahq:master Aug 2, 2024
15 checks passed
@bartsmykla bartsmykla deleted the chore/downgrade-envoy-to-1-30-4-k branch August 2, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants