Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes redundant type definition install instruction #2114

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Removes redundant type definition install instruction #2114

merged 1 commit into from
Nov 7, 2020

Conversation

bfdes
Copy link
Contributor

@bfdes bfdes commented Nov 7, 2020

Summary

New versions of Jest ship with type definitions. Indeed, Jest is being re-written in TypeScript.

Test plan

n/a

Does this PR introduce a breaking change?

n/a

Other information

n/a

@bfdes bfdes marked this pull request as ready for review November 7, 2020 01:01
@bfdes bfdes requested a review from kulshekhar as a code owner November 7, 2020 01:01
@coveralls
Copy link

coveralls commented Nov 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 350481771

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.661%
Totals Coverage Status
Change from base Build 347079302: 0.0%
Covered Lines: 1020
Relevant Lines: 1049
💛 - Coveralls

@ahnpnl ahnpnl merged commit a42de7a into kulshekhar:master Nov 7, 2020
@bfdes bfdes deleted the patch-1 branch November 10, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnpnl ahnpnl ahnpnl approved these changes

@kulshekhar kulshekhar Awaiting requested review from kulshekhar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfdes @coveralls @ahnpnl