kulahe3@rpi.edu #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://tracker.ceph.com/issues/66815 Introduced by:#55838 (comment) Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
We already ignore health warning regarding OSD being down during upgrade but health warning regarding specific OSD being down is not added to the ignorelist which causes upgrade jobs to be marked as failed even though they were successful. Fixes: https://tracker.ceph.com/issues/66877 Signed-off-by: Rishabh Dave <ridave@redhat.com>
Fixes: https://tracker.ceph.com/issues/67182 Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
Additionally, add the flag that does so when cephadm applies a spec during bootstrap. Bootstrap will continue to completion regardless of whether applying the spec fails, so we might as well try applying all of it while reporting errors we do see back to the user Fixes: https://tracker.ceph.com/issues/65338 Signed-off-by: Adam King <adking@redhat.com>
#58868 introduced SnapMapper::update_snap_map to be used both by Crimson and Classic. No change in behavior. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Kevin Zhao <kevin.zhao@linaro.org>
Currently timeout is set to 5. But hardcoding this is unnecessary since the class already defines a attribute for this purpose. Use that instead. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
fixup Signed-off-by: Zac Dover <zac.dover@proton.me>
all objects before them are backfilled Fixes: https://tracker.ceph.com/issues/68147 Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
during Waiting Fixes: https://tracker.ceph.com/issues/68061 Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
collections at the last moment of pg deleting, just as pg meta objects Fixes: https://tracker.ceph.com/issues/68174 Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
We can set the public ip address to set for the cluster using the declarative method by providing the information in the resource description. The corresponding functionality is not available with the imperative method of creating the smb cluster. This patch adds this functionality by allowing the user the option of providing the a public address on the command line when creating the smb cluster. Signed-off-by: Sachin Prabhu <sp@spui.uk>
Use `is` based comparisions for two enum related functions as mypy likes this better. Signed-off-by: John Mulligan <jmulligan@redhat.com>
As distutils is removed from python 3.12 ceph can no longer use the simple conversion function once located in that module. Add our own trivial replacement function. Signed-off-by: John Mulligan <jmulligan@redhat.com>
In python 3.12 distutils is removed. Replace uses of distutils.util.strtobool with our own utility function. Signed-off-by: John Mulligan <jmulligan@redhat.com>
For some reason there's a 'mypy' environment listed in the telemetry tox.ini that always runs pytest. Remove it. We'll see if this causes the CI to fail, as I can't find anywhere that uses it. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Ceph is still very behind on the version of mypy used in the various tox test dirs. Bump up to version 1.9 as it only requires a few trivial fixes to use. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
…ext_messages Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
BlueStore::read_allocation_from_drive_for_bluestore_tool was not informed that multiple bdev labels can exist and reserve space. Comparison of real alloc vs recovered alloc was failing. Fixes: https://tracker.ceph.com/issues/67596 Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
snapshot is retained despite of deletion (using --retain-snapshots option of "subvolume rm" command). Signed-off-by: Rishabh Dave <ridave@redhat.com>
In class RTimer in mgr_util.py, "self.finished.set()" is run even though the event self.finished was set just now. If it wasn't set, the while loop the precedes it would've never finished running. Therefore, remove this redundant line of code. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Fixes: https://tracker.ceph.com/issues/68284 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
necessary in the Enqueuing state Fixes: https://tracker.ceph.com/issues/68175 Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
When an exception occurs in class RTimer of mgr_util.py, only the
exception message is logged but not only this is insufficient for
debugging but also it is hard to spot in logs. This should not be the
case, especially for an occurring exception. Therefore, add code to log
traceback and exception name as well along with exception's message.
Log entry before this patch -
2024-09-27T00:22:38.656+0530 7f05c7e006c0 0 [volumes ERROR mgr_util] task exception: dummy exception for testing
Log entry with this patch -
2024-09-27T00:40:26.509+0530 7f61d64006c0 0 [volumes ERROR mgr_util] exception encountered in RTimer instance "<RTimer(Thread-7, started daemon 140058183075520)>":
Traceback (most recent call last):
File "/home/rishabh/repos/ceph/minor3/src/pybind/mgr/mgr_util.py", line 91, in run
self.function(*self.args, **self.kwargs)
File "/home/rishabh/repos/ceph/minor3/src/pybind/mgr/volumes/fs/stats_util.py", line 232, in _update_progress_bars
raise RuntimeError('dummy exception for testing')
RuntimeError: dummy exception for testing
Signed-off-by: Rishabh Dave <ridave@redhat.com>
In RBM, seastore issues ool writes with allocated address. If a transaction conflict occurs at this point, the allocated address is freed, allowing the address to be reused. However, data inconsistency can occur if seastore issues ool writes with freed address before the preceding ool write has not been complete. To fix this issue, this commit frees the allocated address after ool writes is don in the event of the transaction conflict after ool write is issued. Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Orignally, when the feature was in development, IDs for clone progress bars were set to randomly generated UUID strings. But, eventually, it was decided to assign fixed strings to them. Unlike UUIDs, these strings stay the same even when progress bars are destroyed and re-created. Therefore, instead of re-assigning the same strings every time initiate_reporting() is called, move them to __init__() so that both the IDs are defined only once. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Fixes: https://tracker.ceph.com/issues/68243 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Fixes: https://tracker.ceph.com/issues/68545 Signed-off-by: Avan Thakkar <athakkar@redhat.com>
mgr/cephadm: move Grafana's subpath handling logic to grafan config Reviewed-by: Adam King <adking@redhat.com> Reviewed-by: Ernesto Puerta <epuertat@redhat.com> Reviewed-by: Nizamudeen A <nia@redhat.com>
…ntries log: save/fetch thread name infra Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Fixes: https://tracker.ceph.com/issues/68438 Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
mgr/vol : shortening the name of helper method Reviewed-by: Venky Shankar <vshankar@redhat.com> Reviewed-by: Rishabh Dave <ridave@redhat.com>
Fixes: https://tracker.ceph.com/issues/68434 Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
cephfs-shell: fixing cephfs-shell test failures Reviewed-by: Venky Shankar <vshankar@redhat.com>
…list_default_images cephadm: Added cephadm command to list all the default images Reviewed-by: Adam King <adking@redhat.com> Reviewed-by: John Mulligan <jmulligan@redhat.com>
mgr/dashboard: fix lifecycle issues Reviewed-by: Afreen Misbah <afreen@ibm.com>
Compressor: Add UADK document Reviewed-by: Zac Dover <zac.dover@proton.me>
exporter: New metric for report ceph daemons health
mgr/smb: rm all `smb dump` commands Reviewed-by: Adam King <adking@redhat.com> Reviewed-by: John Mulligan <jmulligan@redhat.com>
orch: disk replacement enhancement Reviewed-by: Adam King <adking@redhat.com>
crimson: replace do_osd_ops* with simpler, more general mechanism Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com> Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Add mgmt-gateway teuthology test scenarios Signed-off-by: Teoman ONAY <tonay@ibm.com>
os/bluestore: Fix ceph-bluestore-tool allocmap command
mgr/vol: don't define progress bar ID repeatedly Reviewed-by: Venky Shankar <vshankar@redhat.com>
mgr/mgr_util: improvements for RTimer Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
mgr/vol: use pre-defined timeout period instead of hardcoded value Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
qa/cephfs: test clone progress reporter after subvol is deleted but... Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
qa/cephfs: ignore when specific OSD is reported down during upgrade Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
rgw: document and label mstart.sh and related scripts Reviewed-by: Patrick Donnelly <pdonnell@ibm.com> Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
mgmt-gateway: add e2e testing Reviewed-by: Adam King <adking@redhat.com>
CodingStyle: allow C++ forward declarations Reviewed-by: Greg Farnum <gfarnum@redhat.com> Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
mon,cephfs: require confirmation when changing max_mds on unhealthy cluster Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
os/bluestore: Fix repair of multilabel when collides with BlueFS
kulahe3
pushed a commit
that referenced
this pull request
Dec 10, 2024
https://vote.heliosvoting.org/helios/elections/e03494ce-e04c-41d0-bb05-ec5ccc632ce4/view Question #1 Update election requirements for Ceph Executive Council Elections? Remove "ranked-choice" requirement 13 Keep "ranked-choice" requirement (no change) 16 Question ceph#2 Require periodic elections in governance charter? No (no change) 8 Annual 15 Semi-annual 3 Quarterly 2 Question ceph#3 Update the Ceph Executive Council term length? Change to 3 years 14 Keep 2 years (no change) 14 Question ceph#4 Amend governance document to require a supermajority of votes for amendments to the governance model? The current requirement is a simple majority. Require a supermajority 20 Require a simple majority (no change) 9 Question ceph#5 Clarify "supermajority" and "majority" election requirements? Of members voting on a given question (abstaining does not bias the vote) 18 Of members voting on the election (abstaining is an implicit "no") 6 Of members in the CSC 3 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e