Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove printf with repo during install #986

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Remove printf with repo during install #986

merged 1 commit into from
Oct 22, 2019

Conversation

alenkacz
Copy link
Contributor

What this PR does / why we need it:
Right now this is output of install

kudo git:(master) ✗ ./bin/kubectl-kudo install ./config/samples/first-operator
repo configs: { name:community, url:https://kudo-repository.storage.googleapis.com }
operator.kudo.dev/v1alpha1/first-operator created
operatorversion.kudo.dev/v1alpha1/first-operator-0.1.0 created
instance.kudo.dev/v1alpha1/first-operator-527jgn created

This PR removes the first line. I find it very cryptic and not aligned with the rest of messages we try to print out even in terms of format.

Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this looks like a debug message, clog.V looks like the right choice.

@zen-dog zen-dog merged commit e68f7f8 into master Oct 22, 2019
@zen-dog zen-dog deleted the av/remove-printf branch October 22, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants