init: handle only "kudo-system" namespace #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
approved these changes
Oct 22, 2019
alenkacz
reviewed
Oct 22, 2019
| secret := webhookSecret(opts) | ||
| var prereqs []runtime.Object | ||
|
|
||
| if opts.Namespace == defaultns { |
There was a problem hiding this comment.
I don't like this duplication (and it's not your fault!)
btw. If you want to follow up with another PR that makes Prereq be used in installPrereq that would be a good cleanup :) If not, I'll do that when this one merges
There was a problem hiding this comment.
Sounds good, if you can provide me some tips: I'm not sure how to do this because installPrereq has only kubernetes.Interface client which operates on typed kubernetes objects, and Prereq returns a slice of untyped objects, which (as I saw in tests) should be managed by controller-runtime Client.
3c2198a to
a7f4115
Compare
Makes `init` command handle only `kudo-system` namespace. Other namespaces are expected to be created beforehand. Fixes kudobuilder#972
|
Thank you @hypnoglow ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes
initcommand handle onlykudo-systemnamespace. Othernamespaces are expected to be created beforehand.
Fixes #972