Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging for init #934

Merged
merged 9 commits into from
Oct 18, 2019
Merged

Better logging for init #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c3e121c
Better logging for init
alenkacz Oct 11, 2019
9bc6dc5
Update pkg/kudoctl/cmd/init/manager.go
alenkacz Oct 11, 2019
41a6ce7
Update pkg/kudoctl/cmd/init/manager.go
alenkacz Oct 11, 2019
53f8e48
Update pkg/kudoctl/cmd/init/manager.go
alenkacz Oct 11, 2019
79cb0ce
Update pkg/kudoctl/cmd/init.go
alenkacz Oct 11, 2019
f0f97ad
Update pkg/kudoctl/cmd/init/manager.go
alenkacz Oct 17, 2019
e24f5ea
Update pkg/kudoctl/cmd/init/manager.go
alenkacz Oct 17, 2019
9d48e24
Improvements
alenkacz Oct 17, 2019
34ea3a1
Remove extra spaces
alenkacz Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/kudoctl/cmd/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func (initCmd *initCmd) run() error {
}

if initCmd.wait {
clog.V(4).Printf("waiting for kudo at server init")
clog.Printf("⌛Waiting for KUDO controller to be ready in your cluster...")
finished := cmdInit.WatchKUDOUntilReady(initCmd.client.KubeClient, opts, initCmd.timeout)
if !finished {
return errors.New("watch timed out, readiness uncertain")
Expand Down
6 changes: 3 additions & 3 deletions pkg/kudoctl/cmd/init/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,19 +59,19 @@ func NewOptions(v string) Options {
// Install uses Kubernetes client to install KUDO.
func Install(client *kube.Client, opts Options, crdOnly bool) error {

clog.V(4).Printf("installing crds")
clog.Printf("✅ installing crds")
if err := installCrds(client.ExtClient); err != nil {
return err
}
if crdOnly {
return nil
}
clog.V(4).Printf("installing prereqs")
clog.Printf("✅ preparing service accounts and other requirements for controller to run")
if err := installPrereqs(client.KubeClient, opts); err != nil {
return err
}

clog.V(4).Printf("installing kudo controller")
clog.Printf("✅ installing kudo controller")
if err := installManager(client.KubeClient, opts); err != nil {
return err
}
Expand Down