Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not mount cert volume when webhook disabled #1176

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Do not mount cert volume when webhook disabled #1176

merged 1 commit into from
Dec 13, 2019

Conversation

alenkacz
Copy link
Contributor

Fixes #1175

zen-dog
zen-dog approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

nfnt
nfnt approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something that we need to test as part of the e2e tests. Unfortunately, this can't be tested with the KUDO test harness currently and we should look how to improve this.

kensipe
kensipe approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@alenkacz alenkacz merged commit 1fd401a into master Dec 13, 2019
@alenkacz alenkacz deleted the av/webhook-mount branch December 13, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@ANeumann82 ANeumann82 ANeumann82 approved these changes

@nfnt nfnt nfnt approved these changes

@zen-dog zen-dog zen-dog approved these changes

@gerred gerred Awaiting requested review from gerred gerred is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.9.0-rc1 manager does not start because of webhook mount
5 participants
@alenkacz @kensipe @ANeumann82 @nfnt @zen-dog