-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor init code into setup package #1161
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
000914c
Refactor init code into setup package
ANeumann82 d07c147
Fixed integration test
ANeumann82 950f1b9
Fixed unset options, improved error messages
ANeumann82 9c4e5bc
Reordered prerequisite init for ServiceAccount and RoleBindings
ANeumann82 4b6ea2d
Fixed integration test expected messages
ANeumann82 a7b24e7
Ensure interfaces are implemented correctly
ANeumann82 1fccba8
Next round of refactoring and reorganizing
ANeumann82 42aad64
Merge branch 'master' into an/refactor-init-setup
ANeumann82 aa6aa42
Fixed yaml serialization
ANeumann82 4ac0052
Fixed yaml serialization
ANeumann82 b606a8d
Dropped "prereq_" prefix from filenames
ANeumann82 3cdef43
Applied code review requests
ANeumann82 e6ac91b
Merge branch 'master' into an/refactor-init-setup
ANeumann82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍 much cleaner