Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend contributing.md with more examples #1134

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Dec 3, 2019

No description provided.

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

IMO we should NOT deploy the manager for make deploy. Who will use make deploy other than developers. I would expect developers to use make run to run manager. (even cli devs).

nice work!

@alenkacz
Copy link
Contributor Author

alenkacz commented Dec 4, 2019

@kensipe yeah I thought about it, I am still not decided. It depends on who is the make-deploy for. We actually inherited it from kubebuilder and there it's their way of deploying what you have into the cluster, they talk about it as deployment method. But I don't think that anyone sane would use it in production, I hope :)

also we cannot easily exclude manager right now because init does not support that and that command would be even more confusing then. I guess then I would pretty much rather remove it altogether :)

Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, more dev docs is always good.

@alenkacz alenkacz merged commit a691658 into master Dec 4, 2019
@alenkacz alenkacz deleted the av/contributing-update branch December 4, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants