Skip to content

Commit

Permalink
Removed the references of Prow in CICD. (#890)
Browse files Browse the repository at this point in the history
  • Loading branch information
orsenthil authored and kensipe committed Oct 2, 2019
1 parent f10e9d2 commit d587d43
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion keps/0004-add-testing-infrastructure.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ These clusters can be started either as a part of CI jobs or maintained long ter

### CICD

We will use a [Prow](https://github.com/kubernetes/test-infra/tree/master/prow) cluster to run jobs for pull requests and merges. The Prow cluster configuration will live in the `kudobuilder/test-infra` repository, it will be hosted on GKE, and it will be reachable at https://prow.kudo.dev/.
CICD is accomplished by a combination of CircleCI and Github Actions enabled for the KUDO repo.

#### Pull Requests

Expand Down
5 changes: 4 additions & 1 deletion keps/0014-pull-request-process.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ owners:
- "@orsenthil"
editor: TBD
creation-date: 2019-07-16
last-updated: 2019-07-16
last-updated: 2019-10-02
status: rejected
see-also:
- KEP-0004
Expand Down Expand Up @@ -36,6 +36,9 @@ see-also:

In order to ensure that contributors to the KUDO project have a good experience, we have a streamlined pull request review and merging process using Prow.

After analyzing prow for few iterations, the team decided to reject prow, and decided to adopt Github Actions for Pull Request Process.
Github Actions provided the desired goal as a service, and it was easier to administer for the project team members. The status of this proposal was changed to rejected.

## Goals

* Automate and enforce labeling of pull requests and issues (e.g., size).
Expand Down

0 comments on commit d587d43

Please sign in to comment.