Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom migration #265

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: support custom migration #265

merged 1 commit into from
Nov 28, 2023

Conversation

Poor12
Copy link
Collaborator

@Poor12 Poor12 commented Nov 10, 2023 •
edited
Loading

To support custom migration we define three types of annotations:

  • kubeadmiral.io/migration-info on source object: User-entered migration strategy.
  • kubeadmiral.io/latest-migration-info on source object: The current migration strategy in effect, read-only.

Test Results:

  1. WorkloadMigration:
    Before migration:
    image
    Add migration info anno:
    image

After migration:
SourceObj:
image
FedObj:
image

  1. ReplicasMigration:
    Before migration:
    image
    Add migration info anno:
    image

After migration:
SourceObj:
image
FedObj:
image

@Poor12 Poor12 force-pushed the support-custom-migration branch 3 times, most recently from 96091ab to 8990818 Compare November 13, 2023 07:21
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (60ba3c8) 28.94% compared to head (43b277c) 29.44%.

Files Patch % Lines
pkg/controllers/statusaggregator/controller.go 0.00% 40 Missing ⚠️
pkg/controllers/scheduler/scheduler.go 24.13% 21 Missing and 1 partial ⚠️
pkg/controllers/scheduler/util.go 74.64% 12 Missing and 6 partials ⚠️
pkg/controllers/scheduler/schedulingunit.go 66.66% 4 Missing and 2 partials ⚠️
...controllers/scheduler/framework/plugins/rsp/rsp.go 40.00% 2 Missing and 1 partial ⚠️
pkg/controllers/scheduler/planner/planner.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   28.94%   29.44%   +0.49%     
==========================================
  Files         114      116       +2     
  Lines       13545    13751     +206     
==========================================
+ Hits         3921     4049     +128     
- Misses       9244     9312      +68     
- Partials      380      390      +10
Flag Coverage Δ
unittests 29.44% <58.55%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poor12 Poor12 force-pushed the support-custom-migration branch 4 times, most recently from 23a2317 to 0f7be85 Compare November 14, 2023 06:29
@Poor12 Poor12 changed the title [WIP]feat: support custom migration feat: support custom migration Nov 14, 2023
@Poor12 Poor12 force-pushed the support-custom-migration branch 2 times, most recently from 87e5dbd to da728c8 Compare November 20, 2023 06:37
@Poor12 Poor12 requested review from gary-lgy, mrlihanbo and limhawjia and removed request for mrlihanbo November 21, 2023 02:52
gary-lgy
gary-lgy requested changes Nov 21, 2023
View reviewed changes
pkg/controllers/federate/controller.go Outdated Show resolved Hide resolved
@Poor12 Poor12 force-pushed the support-custom-migration branch 5 times, most recently from 0f24b99 to e23c181 Compare November 23, 2023 14:07
@Poor12 Poor12 requested review from mrlihanbo and gary-lgy November 24, 2023 03:11
@Poor12 Poor12 force-pushed the support-custom-migration branch from 8501099 to 4313a3b Compare November 27, 2023 13:13
limhawjia
limhawjia approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@limhawjia limhawjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Poor12 Poor12 force-pushed the support-custom-migration branch 2 times, most recently from 654a5b3 to e5b66e8 Compare November 28, 2023 05:02
@Poor12 Poor12 force-pushed the support-custom-migration branch from e5b66e8 to 1344eb0 Compare November 28, 2023 07:26
@Poor12 Poor12 force-pushed the support-custom-migration branch from 1344eb0 to fbbb5d4 Compare November 28, 2023 09:32
@Poor12
feat: support custom migration
43b277c 
Signed-off-by: shentiecheng <shentiecheng@bytedance.com>
@Poor12 Poor12 force-pushed the support-custom-migration branch from fbbb5d4 to 43b277c Compare November 28, 2023 10:10
@gary-lgy gary-lgy merged commit a0834b5 into kubewharf:main Nov 28, 2023
6 of 7 checks passed
miraclejzd pushed a commit to miraclejzd/kubeadmiral that referenced this pull request Jan 3, 2024
@gary-lgy
Merge pull request kubewharf#265 from Poor12/support-custom-migration
2aa5972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-lgy gary-lgy gary-lgy approved these changes

@limhawjia limhawjia limhawjia approved these changes

@mrlihanbo mrlihanbo Awaiting requested review from mrlihanbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Poor12 @gary-lgy @limhawjia @mrlihanbo