Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deckhouse to the Adopters list #8442

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Add Deckhouse to the Adopters list #8442

merged 1 commit into from
Oct 25, 2022

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Sep 9, 2022 •
edited
Loading

What this PR does / why we need it:

This PR adds Deckhouse to the KubeVirt Adopters list.

List of our contributions:

Special notes for your reviewer:

Release note:

Add Deckhouse to the Adopters list

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 9, 2022
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/XS labels Sep 9, 2022
@xpivarc
Copy link
Member

xpivarc commented Sep 9, 2022

/approve
/cc @fabiand

@kvaps Please sign your commit.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 9, 2022
@kubevirt-bot kubevirt-bot requested a review from fabiand September 9, 2022 07:55
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@kvaps kvaps marked this pull request as ready for review September 9, 2022 08:04
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2022
@kubevirt-bot kubevirt-bot requested a review from rmohr September 9, 2022 08:04
maiqueb
maiqueb approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@brianmcarey
Copy link
Member

/retest

@brianmcarey
Copy link
Member

/retest-required

maiqueb
maiqueb suggested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking in more detail, do you mind moving your entry next to the other vendors ?

I think the table is meant to be ordered by user type - first end users, then integrations, finally vendors.

Sorry I only noticed it now.

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
@kvaps
Copy link
Member Author

kvaps commented Oct 21, 2022

Sorry, I was pretty sure that it is in alphabetical order

@kvaps
Add Deckhouse to the Adopters list
f4afffd 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@maiqueb
Copy link
Contributor

maiqueb commented Oct 21, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
maiqueb
maiqueb approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was pretty sure that it is in alphabetical order

All good, no need to apologize. I didn't notice until now ...

@brianmcarey
Copy link
Member

/retest-required

@brianmcarey
Copy link
Member

/test pull-kubevirt-e2e-kind-1.22-sriov

@kubevirt-bot
Copy link
Contributor

@kvaps: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-kind-1.22-sriov-nonroot 7dccaa8 link unknown /test pull-kubevirt-e2e-kind-1.22-sriov-nonroot
pull-kubevirt-e2e-kind-1.23-vgpu f4afffd link unknown /test pull-kubevirt-e2e-kind-1.23-vgpu
pull-kubevirt-e2e-kind-1.22-sriov f4afffd link unknown /test pull-kubevirt-e2e-kind-1.22-sriov
pull-kubevirt-e2e-k8s-1.24-sig-storage-nonroot f4afffd link unknown /test pull-kubevirt-e2e-k8s-1.24-sig-storage-nonroot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot merged commit 4d236ba into kubevirt:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

@acardace acardace Awaiting requested review from acardace

@alicefr alicefr Awaiting requested review from alicefr

@fabiand fabiand Awaiting requested review from fabiand

@rmohr rmohr Awaiting requested review from rmohr

Assignees

@maiqueb maiqueb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kvaps @kubevirt-bot @xpivarc @brianmcarey @maiqueb