-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OWNERS: enable SIGs, WGs and automation code writers to own their folders #360
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,17 @@ | ||
| reviewers: | ||
| - aburdenthehand | ||
| - dhiller | ||
| - jean-edouard | ||
|
|
||
| - reviewers | ||
| approvers: | ||
| - aburdenthehand | ||
| - davidvossel | ||
| - fabiand | ||
| - jean-edouard | ||
| - rmohr | ||
| - vladikr | ||
|
|
||
| - approvers | ||
| emeritus_approvers: | ||
| - karmab # 10 july 2019 | ||
| - tripledes # 10 july 2019 | ||
| - e-minguez # 10 july 2019 | ||
| - joeldavis84 # 10 july 2019 | ||
| - jparrill # 12 Nov 2019 | ||
| - iranzo # April 2020 | ||
| - ptrnull # April 2020 | ||
| - alosadagrande # April 2020 | ||
| - codificat # Jan 2022 | ||
| - mazzystr # Jan 2022 | ||
| - AlonaKaplan # Sep 2024 | ||
| - cwilkers # Sep 2024 | ||
| - karmab # 10 july 2019 | ||
| - tripledes # 10 july 2019 | ||
| - e-minguez # 10 july 2019 | ||
| - joeldavis84 # 10 july 2019 | ||
| - jparrill # 12 Nov 2019 | ||
| - iranzo # April 2020 | ||
| - ptrnull # April 2020 | ||
| - alosadagrande # April 2020 | ||
| - codificat # Jan 2022 | ||
| - mazzystr # Jan 2022 | ||
| - AlonaKaplan # Sep 2024 | ||
| - cwilkers # Sep 2024 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| aliases: | ||
| reviewers: | ||
| - aburdenthehand | ||
| - dhiller | ||
| - jean-edouard | ||
|
|
||
| approvers: | ||
| - aburdenthehand | ||
| - davidvossel | ||
| - fabiand | ||
| - jean-edouard | ||
| - rmohr | ||
| - vladikr | ||
|
|
||
| # | ||
| # automation stuff residing in this repo also needs approvers and reviewers | ||
| # | ||
| code-approvers: | ||
| - dhiller | ||
| - xpivarc | ||
| - vladikr | ||
| - jean-edouard | ||
| code-reviewers: | ||
| - dhiller | ||
| - xpivarc | ||
| - vladikr | ||
| - jean-edouard | ||
|
|
||
| # | ||
| # SIG Test | ||
| # | ||
| sig-test-reviewers: | ||
| - kbidarkar | ||
| sig-test-approvers: | ||
| - kbidarkar | ||
| - phoracek | ||
| - enp0s3 | ||
| - xpivarc | ||
| - acardace | ||
| - dhiller | ||
| - 0xFelix | ||
| sig-test-emeritus_approvers: | ||
| - AlonaKaplan | ||
|
|
||
| # | ||
| # SIG Network | ||
| # Owns anything related to networking. | ||
| # | ||
| sig-network-reviewers: | ||
| - EdDev | ||
| - RamLavi | ||
| - ormergi | ||
| - orelmisan | ||
| sig-network-approvers: | ||
| - EdDev | ||
| - RamLavi | ||
| sig-network-emeritus_approvers: | ||
| - AlonaKaplan | ||
|
|
||
| # | ||
| # SIG Scale | ||
| # Owns to keep kubevirt's scalability comparable to Kubernetes'. | ||
| # | ||
| sig-scale-approvers: | ||
| - rthallisey | ||
| - alaypatel07 | ||
| sig-scale-reviewers: | ||
| - rthallisey | ||
| - alaypatel07 | ||
|
|
||
| # | ||
| # SIG Storage | ||
| # Owns anything related to storage. | ||
| # | ||
| sig-storage-approvers: | ||
| - mhenriks | ||
| - alicefr | ||
| sig-storage-reviewers: | ||
| - awels | ||
| - akalenyu | ||
| - ShellyKa13 | ||
|
|
||
| # | ||
| # SIG API | ||
| # Owns the API including API life-cycle, deprecation, | ||
| # and backwards compatibility. | ||
| # | ||
| sig-api-approvers: [] | ||
| sig-api-reviewers: [] | ||
|
|
||
| # | ||
| # SIG Compute | ||
| # Owns everything which is taking place on a node, for example | ||
| # (but not limited to) groups, SELinux, node labels, … | ||
| # And everything on the cluster level such as RBAC, controller, … | ||
| # | ||
| sig-compute-approvers: | ||
| - jean-edouard | ||
| - iholder101 | ||
| - fossedihelm | ||
| - 0xFelix | ||
| sig-compute-reviewers: | ||
| - victortoso | ||
| - fossedihelm | ||
| - lyarwood | ||
| - 0xFelix | ||
|
|
||
| # SIG Compute Instance types sub project | ||
| # Responsible the overall instance type feature set within SIG Compute | ||
| sig-compute-instancetype-approvers: | ||
| - lyarwood | ||
| - 0xFelix | ||
| sig-compute-instancetype-reviewers: | ||
| - akrejcir | ||
|
|
||
| # | ||
| # SIG Observability | ||
| # Owns the responsibility to keep kubevirt observable by i.e. | ||
| # having mertics, alters, and runbooks. | ||
| # | ||
| sig-observability-approvers: | ||
| - sradco | ||
| - machadovilaca | ||
| sig-observability-reviewers: | ||
| - machadovilaca | ||
| - avlitman | ||
|
|
||
| # | ||
| # SIG Release | ||
| # Owns the release process, including the schedule, and tools. | ||
| # | ||
| sig-release-approvers: | ||
| - acardace | ||
| - fossedihelm | ||
| - xpivarc | ||
| sig-release-reviewers: | ||
| - acardace | ||
| - fossedihelm | ||
| - xpivarc | ||
|
|
||
| # | ||
| # SIG Buildsystem | ||
| # Owns bazel, and ensures that kubevirt can be build. | ||
| # | ||
| sig-buildsystem-approvers: | ||
| - brianmcarey | ||
| - dhiller | ||
| - xpivarc | ||
| sig-buildsystem-reviewers: | ||
| - brianmcarey | ||
| - enp0s3 | ||
| - xpivarc | ||
|
|
||
| # | ||
| # SIG CI | ||
| # | ||
| sig-ci-approvers: | ||
| - brianmcarey | ||
| - dhiller | ||
| sig-ci-reviewers: | ||
| - brianmcarey | ||
| - dhiller | ||
| - enp0s3 | ||
| - xpivarc | ||
|
|
||
| # | ||
| # SIG Architecture | ||
| # Owns the overall architecture, and supporting the growth, health, | ||
| # openess of KubeVirt. | ||
| # | ||
| sig-architecture-approvers: [] | ||
| sig-architecture-reviewers: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - code-approvers | ||
| reviewers: | ||
| - code-reviewers | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - code-approvers | ||
| reviewers: | ||
| - code-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - code-approvers | ||
| reviewers: | ||
| - code-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # TODO: do not forget to add the chairs as approvers and other stakeholders as reviewers | ||
| approvers: [] | ||
| reviewers: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - sig-buildsystem-approvers | ||
| reviewers: | ||
| - sig-buildsystem-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - sig-ci-approvers | ||
| reviewers: | ||
| - sig-ci-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - sig-compute-approvers | ||
| reviewers: | ||
| - sig-compute-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - sig-network-approvers | ||
| reviewers: | ||
| - sig-network-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - sig-observability-approvers | ||
| reviewers: | ||
| - sig-observability-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - sig-scale-approvers | ||
| reviewers: | ||
| - sig-scale-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - sig-storage-approvers | ||
| reviewers: | ||
| - sig-storage-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - code-approvers | ||
| reviewers: | ||
| - code-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # TODO: do not forget to add the chairs as approvers and other stakeholders as reviewers | ||
| approvers: [] | ||
| reviewers: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - zhlhahaha | ||
| reviewers: | ||
| - zhlhahaha |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| approvers: | ||
| - jschintag | ||
| - cfilleke | ||
| - vamsikrishna-siddu | ||
| reviewers: | ||
| - jschintag | ||
| - cfilleke | ||
| - vamsikrishna-siddu | ||
| - chandramerla |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| approvers: | ||
| - EdDev | ||
| - iholder101 | ||
| reviewers: | ||
| - EdDev | ||
| - iholder101 | ||
| - dhiller |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are
code-approversdifferent thanapprovers, same forcode-reviewersandreviewers? why do we need both?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-approversis the group of people that are maintaining the automation code in this repository. Since I couldn't imagine a better name, I stuck to what I found in k/kubevirt, from which this comes - if you insist I could rename it to i.e.automation-code-reviewersandautomation-code-approversor do you have a better suggestion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer
automation-code-*as it is more descriptive.But I'm also perfectly content to not change it since this matches k/kubevirt and the entry has a descriptive note.