fix(): refactoring metric factory to accept prefix for the metrics (#27)

* fix(): refactoring metric factory to accept prefix for the metrics Signed-off-by: Puran Adhikari <puran.adhikari@aveshasystems.com> * fix(): moving prefix set to NewMetricFactory method Signed-off-by: Puran Adhikari <puran.adhikari@aveshasystems.com> --------- Signed-off-by: Puran Adhikari <puran.adhikari@aveshasystems.com>
kubeslice · May 3, 2023 · edd2613 · edd2613
1 parent c583470
commit edd2613
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -18,6 +18,7 @@ type MetricsFactoryOptions struct {
 	Cluster             string
 	Namespace           string
 	ReportingController string
+	Prefix              string
 }
 
 type metricsFactory struct {
@@ -26,6 +27,9 @@ type metricsFactory struct {
 }
 
 func NewMetricsFactory(r prometheus.Registerer, o MetricsFactoryOptions) (MetricsFactory, error) {
+	if o.Prefix == "" {
+		o.Prefix = "kubeslice"
+	}
 	mf := &metricsFactory{
 		Registerer: r,
 		Options:    o,
@@ -58,7 +62,7 @@ func (m *metricsFactory) getCurryLabels(labels []string) ([]string, prometheus.L
 func (m *metricsFactory) NewCounter(name string, help string, labels []string) *prometheus.CounterVec {
 	labels, cl := m.getCurryLabels(labels)
 	return promauto.With(m.Registerer).NewCounterVec(prometheus.CounterOpts{
-		Namespace: "kubeslice",
+		Namespace: m.Options.Prefix,
 		Name:      name,
 		Help:      help,
 	}, labels).MustCurryWith(cl)
@@ -67,7 +71,7 @@ func (m *metricsFactory) NewCounter(name string, help string, labels []string) *
 func (m *metricsFactory) NewGauge(name string, help string, labels []string) *prometheus.GaugeVec {
 	labels, cl := m.getCurryLabels(labels)
 	return promauto.With(m.Registerer).NewGaugeVec(prometheus.GaugeOpts{
-		Namespace: "kubeslice",
+		Namespace: m.Options.Prefix,
 		Name:      name,
 		Help:      help,
 	}, labels).MustCurryWith(cl)
@@ -76,7 +80,7 @@ func (m *metricsFactory) NewGauge(name string, help string, labels []string) *pr
 func (m *metricsFactory) NewHistogram(name string, help string, labels []string) prometheus.ObserverVec {
 	labels, cl := m.getCurryLabels(labels)
 	return promauto.With(m.Registerer).NewHistogramVec(prometheus.HistogramOpts{
-		Namespace: "kubeslice",
+		Namespace: m.Options.Prefix,
 		Name:      name,
 		Help:      help,
 	}, labels).MustCurryWith(cl)