Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): updating elastic examples #3963

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Aug 13, 2024

This PR updates the elastic examples to match the new template

Changes

  • Updates elastic examples to new template

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this Aug 13, 2024
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:18pm

@xoscar xoscar marked this pull request as ready for review August 13, 2024 21:38

## Steps to Stop the Environment
To execute th tests it, run this command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To execute th tests it, run this command:
To execute the tests, run this command:


## Steps to Stop the Environment
To execute th tests it, run this command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To execute th tests it, run this command:
To execute the tests, run this command:

Copy link
Contributor

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of editing suggestions.

Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few links to fix. Otherwise good to go!

2. Name your test and add a description. Hit Next.
3. Configure the GET URL to be `http://app:8080` since the tests will be running in docker compose network. Hit Create.
4. Running the test should succeed.
The [`docker-compose.yaml` file](https://github.com/kubeshop/tracetest/blob/main/examples/tracetest-elasticapm-with-otel/docker-compose.agent.yaml) also contains the Tracetest Agent, OpenTelemetry Collector, Elasticsearch, Kibana, and Elastic APM server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The [`docker-compose.yaml` file](https://github.com/kubeshop/tracetest/blob/main/examples/tracetest-elasticapm-with-otel/docker-compose.agent.yaml) also contains the Tracetest Agent, OpenTelemetry Collector, Elasticsearch, Kibana, and Elastic APM server.
The [`docker-compose.yaml` file](https://github.com/kubeshop/tracetest/blob/main/examples/tracetest-elasticapm-with-otel/docker-compose.yaml) also contains the Tracetest Agent, OpenTelemetry Collector, Elasticsearch, Kibana, and Elastic APM server.


## Open Kibana
The [`docker-compose.yaml` file](https://github.com/kubeshop/tracetest/blob/main/examples/tracetest-elasticapm-with-elastic-agent/docker-compose.agent.yaml) also contains the Tracetest Agent, Elasticsearch, Kibana, and Elastic APM server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The [`docker-compose.yaml` file](https://github.com/kubeshop/tracetest/blob/main/examples/tracetest-elasticapm-with-elastic-agent/docker-compose.agent.yaml) also contains the Tracetest Agent, Elasticsearch, Kibana, and Elastic APM server.
The [`docker-compose.yaml` file](https://github.com/kubeshop/tracetest/blob/main/examples/tracetest-elasticapm-with-elastic-agent/docker-compose.yaml) also contains the Tracetest Agent, Elasticsearch, Kibana, and Elastic APM server.

@xoscar xoscar merged commit c154c25 into main Aug 14, 2024
38 checks passed
@xoscar xoscar deleted the chore-updating-elastic-examples branch August 14, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants