Add/run groups to cli #3753
Add/run groups to cli #3753
Conversation
add run group reporter to CLI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| runCmd.Flags().StringVarP(&runParams.DefinitionFile, "file", "f", "", "path to the definition file") | ||
| runCmd.Flags().StringVar(&runParams.ID, "id", "", "id of the resource to run") | ||
| runCmd.Flags().StringSliceVarP(&runParams.DefinitionFiles, "file", "f", []string{}, "path to the definition file (can be defined multiple times)") | ||
| runCmd.Flags().StringVarP(&runParams.ID, "id", "", "", "id of the resource to run (can be defined multiple times)") |
There was a problem hiding this comment.
I thought about having multiple IDs, but I reverted the changes and forgot to change here:
| runCmd.Flags().StringVarP(&runParams.ID, "id", "", "", "id of the resource to run (can be defined multiple times)") | |
| runCmd.Flags().StringVarP(&runParams.ID, "id", "", "", "id of the resource to run") |
There was a problem hiding this comment.
If you don't mind, I'll fix this in the next PR, I want to have this merged 🥴
| // ExitCLI will exit the process, so this return is just to satisfy the compiler | ||
| return "", err |
There was a problem hiding this comment.
I remember this comic every time we need to satisfy our Go compiler xD :
There was a problem hiding this comment.
Man the compiler is really strict haha
cli/formatters/multiple_runs.go
Outdated
There was a problem hiding this comment.
Since this formatter is only used on Cloud features, does it make sense to move it to the cloud package?
There was a problem hiding this comment.
Once we finish this feature, I'll create a cleanup PR with some changes, I believe we might not need the separation between cloud and OSS, even if someone wants to replicate the behavior, it is handled by the server side which wont be supported by the OSS server
This PR...
Changes
Fixes
Checklist
Loom video
Add your loom video here if your work can be visualized