chore(agent): make docker image multiarch #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
commented
Oct 18, 2023
| @@ -102,20 +102,6 @@ jobs: | |||
| ANALYTICS_BE_KEY: ${{ secrets.ANALYTICS_BE_KEY }} | |||
| TRACETEST_DEFAULT_CLOUD_ENDPOINT: ${{ secrets.TRACETEST_DEFAULT_CLOUD_ENDPOINT }} | |||
|
|
|||
| # release agent | |||
There was a problem hiding this comment.
this is now handled by goreleaser on the main release step
jorgeepc
approved these changes
Oct 18, 2023
danielbdias
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the agent docker image mutliarch. For simplicity, it uses the same approach as the main tracetest image. Meaning the building happens through goreleaser. Because of how goreleaser works, it was not practical to keep the agent image "inheriting" from the main tracetest image, instead the easiest way was to have a dockerfile that simply imports the already built cli binary and set an entrypoint.
Checklist