fix(agent): Graceful Stop #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Oct 5, 2023
| @@ -138,3 +140,7 @@ func (c *Client) getName() (string, error) { | |||
|
|
|||
| return hostname, nil | |||
| } | |||
|
|
|||
| func isCancelledError(err error) bool { | |||
There was a problem hiding this comment.
I didn't find a good way of doing this, the RPC message contains a wrapped error that when I tried to unwrap it was returning a plane interface{} object 🤷🏾
There was a problem hiding this comment.
Did you try:
errors.Is(err, context.Canceled)
There was a problem hiding this comment.
Yeah, but it didn't work 😢
mathnogueira
approved these changes
Oct 5, 2023
danielbdias
approved these changes
Oct 5, 2023
Comment on lines
30
to
32
| if err != nil { | ||
| log.Fatal("could not get message from trigger stream: %w", err) | ||
| log.Fatal("could not get shutdown listener: %w", err) | ||
| } |
There was a problem hiding this comment.
Does forcing a shutdown here in case of an error make sense? Something like using: os.Exit(-1).
There was a problem hiding this comment.
I believe log.Fatal is already doing that
// Fatal is equivalent to Print() followed by a call to os.Exit(1).
func Fatal(v ...any) {
std.Output(2, fmt.Sprint(v...))
os.Exit(1)
}
| return | ||
| } | ||
|
|
||
| if err != nil { | ||
| log.Fatal("could not get message from trigger stream: %w", err) | ||
| log.Fatal("could not get message from ds connection stream: %w", err) |
There was a problem hiding this comment.
Suggested change
| log.Fatal("could not get message from ds connection stream: %w", err) | |
| log.Fatal("could not get message from data store connection stream: %w", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem when trying to stop the agent from the CLI option
Changes
Fixes
Checklist
Loom video
https://www.loom.com/share/d0bf6ba20a074b16811e5524b20bb36f