Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't update transaction file other than adding id to it #2884

Merged
merged 3 commits into from
Jul 7, 2023
Merged

fix: don't update transaction file other than adding id to it #2884

merged 3 commits into from
Jul 7, 2023

Conversation

mathnogueira
Copy link
Contributor

This PR prevents the CLI from updating the transaction file from being updated with the pre-processed file content.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

schoren
schoren approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM!

@mathnogueira mathnogueira marked this pull request as ready for review July 7, 2023 14:41
@mathnogueira mathnogueira merged commit 5bb04da into main Jul 7, 2023
@mathnogueira mathnogueira deleted the fix/dont-write-test-ids-transaction branch July 7, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathnogueira @schoren