-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Kubernetes installation docs #2562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnanrahic
suggested changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some tiny suggestions. Wonderful work here @danielbdias !!!
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
adnanrahic
approved these changes
May 22, 2023
danielbdias
added a commit
that referenced
this pull request
May 22, 2023
* Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
schoren
pushed a commit
that referenced
this pull request
May 23, 2023
* Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
danielbdias
added a commit
that referenced
this pull request
May 23, 2023
* Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
danielbdias
added a commit
that referenced
this pull request
May 23, 2023
* Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
danielbdias
added a commit
that referenced
this pull request
May 25, 2023
* Add documentation about mapped CLI e2e to do * Apply suggestions from code review Co-authored-by: Julianne Fermi <julianne@kubeshop.io> * fix(docs): fix docs related to data stores (#2558) * Updating Kubernetes installation docs (#2562) * Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io> * docs(install-deploy): improves Deployment and Getting Started pages (#2567) * docs(deployment): clean up formatting * docs(detailed-install): improved explanation, added link to Helm docs * chore: upgrade goreleaser version to v1.18.2 (#2572) * feat: migrate transactions to new resourcemanager architecture (#2551) * feat: support dashes in attribute names (#2569) * Update CLI e2e test engine to support CLI debug and add error handling for 404 errors on Get (#2573) * hotfix: fix controller (#2574) * Improve test output and remove parallelism (#2575) --------- Co-authored-by: Julianne Fermi <julianne@kubeshop.io> Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com> Co-authored-by: Adnan Rahić <adnan@kubeshop.io> Co-authored-by: Sebastian Choren <schoren@users.noreply.github.com> Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
schoren
added a commit
that referenced
this pull request
Jun 5, 2023
* Add documentation about mapped CLI e2e to do * Apply suggestions from code review Co-authored-by: Julianne Fermi <julianne@kubeshop.io> * fix(docs): fix docs related to data stores (#2558) * Updating Kubernetes installation docs (#2562) * Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io> * docs(install-deploy): improves Deployment and Getting Started pages (#2567) * docs(deployment): clean up formatting * docs(detailed-install): improved explanation, added link to Helm docs * chore: upgrade goreleaser version to v1.18.2 (#2572) * feat: migrate transactions to new resourcemanager architecture (#2551) * feat: support dashes in attribute names (#2569) * Update CLI e2e test engine to support CLI debug and add error handling for 404 errors on Get (#2573) * hotfix: fix controller (#2574) * Improve test output and remove parallelism (#2575) --------- Co-authored-by: Julianne Fermi <julianne@kubeshop.io> Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com> Co-authored-by: Adnan Rahić <adnan@kubeshop.io> Co-authored-by: Sebastian Choren <schoren@users.noreply.github.com> Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Kubernetes deployment docs to consider our Helm charts and enable our users to do custom installations with Helm.
Changes
Checklist