-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 1 of v0.11.3 Doc Updates #2379
Conversation
Editing and screenshot updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jfermi this looks great, I added a comment
@@ -25,7 +25,9 @@ You need your SignalFx: | |||
|
|||
Follow this [guide](https://docs.splunk.com/Observability/references/organizations.html). | |||
|
|||
![](https://res.cloudinary.com/djwdcmwdz/image/upload/v1674644337/Blogposts/Docs/screely-1674644332529_cks0lw.png) | |||
![SignalFX](../img/SignalFX-settings.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the npm run build
command in the docs
folder I get an error about this image being missing, do you mind taking a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
- Selector | ||
- Selectors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just added a small comment about possibly adding the name as part of the test spec sections
Editing and screenshot updates.
This PR...
Changes
Fixes
Checklist