Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly detect OOMKilled error on GKE #5761

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: properly detect OOMKilled error on GKE #5761

merged 1 commit into from
Aug 14, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

  • detect Killed Process/Container based on Killed Child Processes
    • GKE for some reason is not signaling nor killing the Init Process
  • avoid reading step statuses from termination log in case of abort
    • Automated heuristics in that case are better

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner August 14, 2024 09:57
@rangoo94 rangoo94 merged commit c7a1224 into develop Aug 14, 2024
21 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/detect-oomkilled-on-gke branch August 14, 2024 10:04
rangoo94 added a commit that referenced this pull request Aug 14, 2024
@rangoo94
fix: properly detect OOMKilled error on GKE (#5761)
ec74616
rangoo94 added a commit that referenced this pull request Aug 14, 2024
@rangoo94
fix: properly detect OOMKilled error on GKE (#5761)
1b69845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejanzele dejanzele dejanzele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @dejanzele