Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TKC-2217): include Toolkit operations in other containers #5740

Merged
merged 15 commits into from
Aug 7, 2024
Merged

feat(TKC-2217): include Toolkit operations in other containers #5740

merged 15 commits into from
Aug 7, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Aug 7, 2024 •
edited
Loading

Pull request description

  • Minimize the number of containers used for the Test Workflow
    • Thanks to that, more operations will happen in Container instead of InitContainer, having access to i.e. Envoy Proxy
    • The safe Toolkit operations will be ran in the context of other containers, as the Toolkit will be copied into shared volume
  • Include Init Process in the Toolkit image as well
    • Thanks to that, we may be able to limit used containers to single one, when only the orchestration is ran (like execute, clone or parallel)

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Fixes

@rangoo94 rangoo94 requested review from a team as code owners August 7, 2024 08:30
rangoo94 added 14 commits August 7, 2024 10:54
@rangoo94 rangoo94 force-pushed the dawid/feat/support-copying-toolkit branch from 12b03af to 8c76e2c Compare August 7, 2024 08:54
@rangoo94 rangoo94 mentioned this pull request Aug 7, 2024
Closed
@rangoo94 rangoo94 merged commit 7078f4f into develop Aug 7, 2024
7 checks passed
@rangoo94 rangoo94 deleted the dawid/feat/support-copying-toolkit branch August 7, 2024 11:12
rangoo94 added a commit that referenced this pull request Aug 14, 2024
@rangoo94
feat(TKC-2217): include Toolkit operations in other containers (#5740)
2b17c38 
* feat: include Init Process in the Toolkit image
* feat: copy the Toolkit binary to the volume
* feat: copy only the Busybox binaries from Toolkit image
* chore: clean up actions optimization code a bit
* chore: don't process setup step in action optimizations
* feat: add `pure` flag for the ContainerStage to define if it can be combined with other container
* feat: fit pure operations in TestWorkflow into other containers
* fix: ensure timestamps for step results in case of aborting
* feat: make `fetch` operation pure too
* chore: delete obsolete comments
* fix: unit tests and bugfixes
* fix: use proper image for setup step
rangoo94 added a commit that referenced this pull request Aug 14, 2024
@rangoo94
feat(TKC-2217): include Toolkit operations in other containers (#5740)
81fbdad 
* feat: include Init Process in the Toolkit image
* feat: copy the Toolkit binary to the volume
* feat: copy only the Busybox binaries from Toolkit image
* chore: clean up actions optimization code a bit
* chore: don't process setup step in action optimizations
* feat: add `pure` flag for the ContainerStage to define if it can be combined with other container
* feat: fit pure operations in TestWorkflow into other containers
* fix: ensure timestamps for step results in case of aborting
* feat: make `fetch` operation pure too
* chore: delete obsolete comments
* fix: unit tests and bugfixes
* fix: use proper image for setup step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exu exu exu approved these changes

@povilasv povilasv povilasv approved these changes

@ed382 ed382 ed382 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rangoo94 @exu @povilasv @ed382