Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add job template field for executor #1023

Merged
merged 6 commits into from
Feb 28, 2022
Merged

feat: add job template field for executor #1023

merged 6 commits into from
Feb 28, 2022

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Feb 23, 2022 •
edited
Loading

Pull request description

Support custom job specification for executor

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@vsukhin vsukhin marked this pull request as ready for review February 25, 2022 13:19
@vsukhin vsukhin self-assigned this Feb 28, 2022
@vsukhin vsukhin merged commit 08010f4 into main Feb 28, 2022
@vsukhin vsukhin deleted the vsukhin/feature/custom-job-spec branch February 28, 2022 11:35
vsukhin added a commit that referenced this pull request Feb 28, 2022
@vsukhin
Revert "feat: add job template field for executor (#1023)"
6a8f6e5 
This reverts commit 08010f4.
vsukhin added a commit that referenced this pull request Feb 28, 2022
@vsukhin
Revert "feat: add job template field for executor (#1023)" (#1030)
8d5890c 
This reverts commit 08010f4.

Co-authored-by: Vladislav Sukhin <vladislav@kubeshop.io>
vsukhin added a commit that referenced this pull request Feb 28, 2022
@vsukhin
Revert "Revert "feat: add job template field for executor (#1023)" (#…
8404c79 
…1030)"

This reverts commit 8d5890c.
vsukhin added a commit that referenced this pull request Mar 1, 2022
@vsukhin
fix: return job spec (#1033)
720d12b 
* Revert "Revert "feat: add job template field for executor (#1023)" (#1030)"

This reverts commit 8d5890c.

* fix: log job spec

Co-authored-by: Vladislav Sukhin <vladislav@kubeshop.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicufk nicufk nicufk approved these changes

@exu exu Awaiting requested review from exu

@jasmingacic jasmingacic Awaiting requested review from jasmingacic

Assignees

@vsukhin vsukhin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsukhin @nicufk