Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create overlays docs #990

Merged
merged 1 commit into from
Nov 29, 2022
Merged

create overlays docs #990

merged 1 commit into from
Nov 29, 2022

Conversation

aabedraba
Copy link

Signed-off-by: Abdallah Abedraba aabedraba@gmail.com

This PR...

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

create overlays docs
b937900 
Signed-off-by: Abdallah Abedraba <aabedraba@gmail.com>
@netlify
Copy link

netlify bot commented Nov 29, 2022 •
edited
Loading

✅ Deploy Preview for kusk-docs-preview ready!

Name Link
🔨 Latest commit b937900
🔍 Latest deploy log https://app.netlify.com/sites/kusk-docs-preview/deploys/638611d119210d0008aa9973
😎 Deploy Preview https://deploy-preview-990--kusk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mbana
mbana approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@mbana mbana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please try searching for:

  1. OpenAPI Overlays
  2. Overlay
  3. Overlays

And see if the OpenAPI Overlays page shows up. In my case, when accessing the preview documentation, it did not.

@aabedraba aabedraba merged commit 7eb2f70 into main Nov 29, 2022
@aabedraba aabedraba deleted the overlays-docs branch November 29, 2022 14:13
@aabedraba aabedraba mentioned this pull request Nov 29, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbana mbana mbana approved these changes

@jasmingacic jasmingacic Awaiting requested review from jasmingacic

@kylehodgetts kylehodgetts Awaiting requested review from kylehodgetts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabedraba @mbana