Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't build ARM images for PR runs #979

Merged
merged 2 commits into from
Nov 21, 2022
Merged

don't build ARM images for PR runs #979

merged 2 commits into from
Nov 21, 2022

Conversation

jasmingacic
Copy link
Contributor

Signed-off-by: jasmingacic jasmin.gacic@gmail.com

Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for kusk-docs-preview canceled.

Name Link
🔨 Latest commit bc4fb85
🔍 Latest deploy log https://app.netlify.com/sites/kusk-docs-preview/deploys/637b76866693770009876a71

Copy link
Contributor

@mbana mbana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Worthy of a trial.

It just means anyone on ARM64 can't run pushed PR image. It's not a big deal.

@jasmingacic
Copy link
Contributor Author

As a reference for how much time we are getting by merging this please checkout build times before
https://github.com/kubeshop/kusk-gateway/actions/runs/3514329218/jobs/5888268104
and now
https://github.com/kubeshop/kusk-gateway/actions/runs/3514421482/jobs/5888590548

from this small sample I can tell we are going to be able to save about 45sec for each PR run.

@jasmingacic jasmingacic merged commit 841b792 into main Nov 21, 2022
@jasmingacic jasmingacic deleted the CI_PR_run branch November 21, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants