Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: websocket logs endpoint for polling envoy fleet logs #946

Merged
merged 8 commits into from
Nov 25, 2022
Merged

API: websocket logs endpoint for polling envoy fleet logs #946

merged 8 commits into from
Nov 25, 2022

Conversation

kylehodgetts
Copy link
Contributor

@kylehodgetts kylehodgetts commented Nov 3, 2022 •
edited
Loading

Changes:

  • update rbac to allow kusk api websocket to poll pod logs
  • add kusk-gateway-api service account (installing via kusk assigned the kusk-manager role to the api)
  • add websocket container to api deployment
  • add websocket port to api service
  • add /logs endpoint to api's openapi spec

mbana
mbana approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@mbana mbana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@netlify
Copy link

netlify bot commented Nov 3, 2022 •
edited
Loading

✅ Deploy Preview for kusk-docs-preview canceled.

Name Link
🔨 Latest commit 08dec0f
🔍 Latest deploy log https://app.netlify.com/sites/kusk-docs-preview/deploys/6380adbf54daea00095f5a5c

@kylehodgetts kylehodgetts changed the title RBAC API: allow fetching pods and pod logs from all namespaces API: websocket logs endpoint for polling envoy fleet logs Nov 8, 2022
mbana
mbana suggested changes Nov 11, 2022
View reviewed changes
cmd/kusk/manifests/api_server.yaml Outdated Show resolved Hide resolved
@jasmingacic
Copy link
Contributor

Should we merge this?

mbana
mbana suggested changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@mbana mbana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install:

go install github.com/go-bindata/go-bindata/v3/go-bindata@v3.1.3

And generate cmd/kusk/cmd/manifest_data.go again. Also, please see comment about the image not being available on DockerHub.

cmd/kusk/manifests/api_server.yaml Show resolved Hide resolved
cmd/kusk/manifests/api_server.yaml Outdated Show resolved Hide resolved
mbana
mbana approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@mbana mbana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kylehodgetts kylehodgetts merged commit ac8e431 into main Nov 25, 2022
@kylehodgetts kylehodgetts deleted the kylehodgetts/feature/rbac-stream-logs-websocket branch November 25, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmingacic jasmingacic jasmingacic approved these changes

@mbana mbana mbana approved these changes

@aabedraba aabedraba Awaiting requested review from aabedraba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylehodgetts @jasmingacic @mbana