767 add gateway #877
767 add gateway #877
Conversation
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
✅ Deploy Preview for kusk-docs-preview canceled.
|
|
Why not group this and api under deploy? |
I actually think it makes sense if it fits under the |
|
@donnalux This is just a preview how the wizard behaves:
Nothing is set in stone so we can move it as @kylehodgetts and @aabedraba said above |
|
If selecting incorrect port: |
|
@jasmingacic proud parent here, I have no feedback, it looks and reads great. As for the command itself, these are the options mentioned: kusk gateway add I quite like "kusk deploy gateway" since it fits nicely with existing pattern. |
|
This is missing option to remove the gateway. I will have it added soon |
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
|
|
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
| @@ -129,4 +129,4 @@ spec: | |||
| selector: | |||
| app.kubernetes.io/instance: kusk-gateway-api | |||
| app.kubernetes.io/name: kusk-gateway-api | |||
| type: LoadBalancer | |||
| type: ClusterIP | |||
There was a problem hiding this comment.
For some reason I changed this into LoadBalancer in previous commits. Here I reverted it.
Fixes #767
Fixes #764