make create-env: Use minikube image load
#854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building the image in the `minikube` docker environment, build it on the host. I.e., remove `eval $$(minikube docker-env --profile kgw); docker build` in favour of: ```sh $ docker build ... $ minikube image --profile kgw load kubeshop/kusk-gateway:$(git describe --tags $(git rev-list --tags --max-count=1)) ``` This should result in faster builds if you delete the `minikube` cluster and re-create as the `kubeshop/kusk-gateway:$(git describe --tags $(git rev-list --tags --max-count=1))` images are not being built in the `minikube` docker daemon so its layers are cached. Results ------- I benchmarked the changes: **Old**: ```sh $ hyperfine --runs 3 'minikube delete --profile kgw && time make create-env' Benchmark 1: minikube delete --profile kgw && time make create-env Time (mean ± σ): 97.866 s ± 2.965 s [User: 32.466 s, System: 7.927 s] Range (min … max): 94.516 s … 100.156 s 3 runs ``` **New**: ```sh $ hyperfine --runs 3 'minikube delete --profile kgw && time make create-env' Benchmark 1: minikube delete --profile kgw && time make create-env Time (mean ± σ): 65.146 s ± 0.983 s [User: 30.162 s, System: 6.345 s] Range (min … max): 64.340 s … 66.241 s 3 runs ``` Signed-off-by: Mohamed Bana <mohamed@bana.io>
✅ Deploy Preview for kusk-docs-preview canceled.
|
kylehodgetts
approved these changes
Oct 10, 2022
jasmingacic
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building the image in the
minikubedocker environment, build it on the host. I.e., removeeval $$(minikube docker-env --profile kgw); docker buildin favour of:$ docker build ... $ minikube image --profile kgw load kubeshop/kusk-gateway:$(git describe --tags $(git rev-list --tags --max-count=1))This should result in faster builds if you delete the
minikubecluster and re-create as thekubeshop/kusk-gateway:$(git describe --tags $(git rev-list --tags --max-count=1))images are not being built in theminikubedocker daemon so its layers are cached.Results
I benchmarked the changes:
Old:
New:
Signed-off-by: Mohamed Bana mohamed@bana.io
Could you please try out this branch to ensure it works in whatever setup you use.