added customized help command #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kusk-docs-preview canceled.
|
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
|
|
aabedraba
reviewed
Oct 9, 2022
Co-authored-by: Abdallah Abedraba <aabedraba@gmail.com>
mbana
approved these changes
Oct 10, 2022
| reportError(err) | ||
| return err | ||
| } | ||
| kuskui.PrintStart("kusk upgraded") | ||
| } | ||
| } | ||
|
|
||
| if err := utils.WaitForPodsReady(cmd.Context(), c, namespace, name, time.Duration(5*time.Minute), "component"); err != nil { |
There was a problem hiding this comment.
Minor point, but this looks very similar to:
if err := utils.WaitForPodsReady(cmd.Context(), c, namespace, "envoy", time.Duration(5*time.Minute), "component"); err != nil {
envoyFleetSpinner.Fail("Failed upgrading EnvoyFleet", err.Error())
reportError(err)
return err
}Perhaps in the future move this into a separate function?
cmd/kusk/cmd/root.go
Outdated
| func help(c *cobra.Command, s []string) { | ||
|
|
||
| switch c.Use { | ||
| case "mock": |
There was a problem hiding this comment.
Cannot you not use the .Use field in the different commands instead of strings in the case statements? E.g.,
case mockCmd.Use
Would work here I believe?
If it doesn't work, I'd just leave it as-is.
| @@ -128,20 +79,20 @@ $ kusk mock -i https://url.to.api.com | |||
| if err != nil { | |||
| err := fmt.Errorf("unable to fetch user's home directory: %w", err) | |||
| reportError(err) | |||
| ui.Fail(err) | |||
| kuskui.PrintError(err.Error()) | |||
There was a problem hiding this comment.
Can you not just make this take an error object?
I see kuskui.PrintError(err.Error()) being repeated in a lot of places.
There was a problem hiding this comment.
Print error accepts array of strings which is usually practical for constructing different error messages. So i'd leave it like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added spinner to the install command
fixes #668
fixes #670