Add Chart for Envoy deployments #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehodgetts
commented
Oct 7, 2021
Tarick
suggested changes
Oct 7, 2021
deploy/envoy/README.md
Outdated
|
|
||
| | Name | Email | Url | | ||
| | ---- | ------ | --- | | ||
| | slamdev | valentin.fedoskin@gmail.com | | |
| args: | ||
| - sh | ||
| - -c | ||
| - apk add perl && cp /opt/envoy.yaml.tpl /config/envoy.yaml && perl -pi -e 's/ENV_([_A-Z0-9]+)_ENV/$ENV{$1}/g' /config/envoy.yaml |
There was a problem hiding this comment.
welp, that no go - we can't run these commands during each pod start. I suggest removing this init container completely and use only config map with envoy.yaml
deploy/envoy/templates/ingress.yaml
Outdated
| @@ -0,0 +1,53 @@ | |||
| {{- if .Values.ingress.enabled -}} | |||
There was a problem hiding this comment.
We don't need ingress object completely
Tarick
suggested changes
Oct 8, 2021
deploy/envoy/Chart.yaml
Outdated
| type: application | ||
| version: 0.0.10 | ||
| appVersion: "v1.18.2" | ||
| home: https://github.com/slamdev/helm-charts/tree/master/charts/envoy |
deploy/envoy/README.md
Outdated
|
|
||
| Helm chart to deploy [envoy](https://www.envoyproxy.io/). | ||
|
|
||
| **Homepage:** <https://github.com/slamdev/helm-charts/tree/master/charts/envoy> |
Tarick
previously approved these changes
Oct 8, 2021
Tarick
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5
Changes
Checklist