Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup remote debugging of manager while it's running in cluster #74

Merged
merged 10 commits into from
Nov 2, 2021
Merged

Setup remote debugging of manager while it's running in cluster #74

merged 10 commits into from
Nov 2, 2021

Conversation

kylehodgetts
Copy link
Contributor

@kylehodgetts kylehodgetts commented Nov 1, 2021 •
edited
Loading

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@kylehodgetts kylehodgetts changed the title Kylehodgetts/cluster debug Setup remote debugging manager while it's running in cluster Nov 2, 2021
@kylehodgetts kylehodgetts marked this pull request as ready for review November 2, 2021 11:12
@kylehodgetts kylehodgetts changed the title Setup remote debugging manager while it's running in cluster Setup remote debugging of manager while it's running in cluster Nov 2, 2021
dobegor
dobegor previously approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@dobegor dobegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment

config/default/manager_debug.yaml Outdated Show resolved Hide resolved
Tarick
Tarick previously approved these changes Nov 2, 2021
View reviewed changes
@kylehodgetts kylehodgetts dismissed stale reviews from Tarick and dobegor via 91c4b29 November 2, 2021 13:38
@kylehodgetts kylehodgetts merged commit d1d59bd into main Nov 2, 2021
@kylehodgetts kylehodgetts deleted the kylehodgetts/cluster-debug branch November 2, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobegor dobegor dobegor left review comments

@Tarick Tarick Tarick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylehodgetts @Tarick @dobegor