Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Mocking media types #238

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

Tarick
Copy link
Contributor

@Tarick Tarick commented Feb 28, 2022

This PR...

Changes

Adds handling of multiple media types for the Mocking, depending on Accept header that client specifies. If no Accept header specified, used the application/json if it is present in the list or the first in the list if not.

Fixes

Closes #231

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

docs/extension.md Outdated Show resolved Hide resolved
internal/agent/httpserver/handlers.go Show resolved Hide resolved
internal/agent/httpserver/negotiator.go Show resolved Hide resolved
internal/agent/httpserver/negotiator.go Show resolved Hide resolved
internal/agent/httpserver/negotiator.go Show resolved Hide resolved
Tarick and others added 2 commits February 28, 2022 11:31
Co-authored-by: Kyle Hodgetts <kyle@kubeshop.io>
@Tarick Tarick requested a review from kylehodgetts February 28, 2022 13:23
@Tarick Tarick merged commit de2ebbd into main Feb 28, 2022
@Tarick Tarick deleted the tyatsurak/enhancement/231-mocking-mediatypes branch February 28, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants