Auto Redirect to HTTPS - EnvoyFleet TLS Requirement setting #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarick
suggested changes
Feb 22, 2022
…iven EnvoyFleets list of hosts to redirect to HTTPS on
Tarick
previously approved these changes
Feb 23, 2022
dobegor
previously approved these changes
Feb 23, 2022
Tarick
previously approved these changes
Feb 28, 2022
Tarick
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the TLS requirements field to set the TLS requirement for redirecting to HTTPS from HTTP
The available options as per envoy are:
NONE - No TLS requirement for the virtual hosts
EXTERNAL_ONLY - External requests must use TLS. If a request is external and it is not using TLS, a 301 redirect will be sent telling the client to use HTTPS.
ALL - All requests must use TLS. If a request is not using TLS, a 301 redirect will be sent telling the client to use HTTPS.
This PR also introduces a Defaulting webhook for EnvoyFleet to set the requirements value to NONE if not set by the user
Checklist