Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS SNI with hostnames #186

Merged
merged 8 commits into from
Jan 20, 2022
Merged

Conversation

kylehodgetts
Copy link
Contributor

@kylehodgetts kylehodgetts commented Jan 17, 2022

This PR enforces hostnames on SSL certificates specified in EnvoyFleets and creates a filterchain for HTTPS traffic from those server names

Changes

  • Add cert package for decoding certificates from bytes
  • If the leaf cert (last one in chain) doesnt have any server names set, return error
  • Set up tls filterchain with host names and existing http connection manager

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Kyle Hodgetts added 3 commits January 17, 2022 19:33
cert/cert.go Outdated Show resolved Hide resolved
@kylehodgetts kylehodgetts requested a review from Tarick January 19, 2022 08:54
@kylehodgetts kylehodgetts marked this pull request as ready for review January 19, 2022 08:54
@kylehodgetts kylehodgetts requested a review from dobegor January 19, 2022 09:01
@kylehodgetts kylehodgetts merged commit 484d42e into main Jan 20, 2022
@kylehodgetts kylehodgetts deleted the kylehodgetts/feature/tls-sni branch January 20, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants