-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS: with static certificates #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarick
reviewed
Jan 10, 2022
kylehodgetts
commented
Jan 11, 2022
kylehodgetts
commented
Jan 11, 2022
Tarick
reviewed
Jan 11, 2022
Tarick
reviewed
Jan 12, 2022
Tarick
suggested changes
Jan 12, 2022
Tarick
suggested changes
Jan 12, 2022
Tarick
approved these changes
Jan 12, 2022
Tarick
pushed a commit
that referenced
this pull request
Jan 14, 2022
Adds support for specifying TLS options in an EnvoyFleet * an array of CipherSuites * TLS min and max versions * an array of cert and key pairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #33
Changes
Adds support for specifying TLS options in an EnvoyFleet
Testing
make create-env
issuer.yaml
andcertificate.yaml
(below)kubectl apply -f config/samples/gateway_v1_envoyfleet.yaml
issuer.yaml
certificate.yaml
Checklist