Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial doc for traffic splitting #1028

Merged
merged 2 commits into from
Dec 15, 2022
Merged

initial doc for traffic splitting #1028

merged 2 commits into from
Dec 15, 2022

Conversation

jasmingacic
Copy link
Contributor

Signed-off-by: jasmingacic jasmin.gacic@gmail.com
Closes #1021

Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for kusk-docs-preview ready!

Name Link
🔨 Latest commit 88ce906
🔍 Latest deploy log https://app.netlify.com/sites/kusk-docs-preview/deploys/639869ede4f90d0008950391
😎 Deploy Preview https://deploy-preview-1028--kusk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mbana
mbana previously requested changes Dec 13, 2022
Copy link
Contributor

@mbana mbana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/sidebars.js needs to include docs/docs/guides/traffic_splitting.md, I think. @aabedraba, am I correct?

You can run make docs-preview locally to verify.

Otherwise looks good.

Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
Copy link
Contributor

@mbana mbana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasmingacic
Copy link
Contributor Author

@aabedraba please take a look

@jasmingacic jasmingacic merged commit 681fbe1 into main Dec 15, 2022
@jasmingacic jasmingacic deleted the traffic_splitting_docs branch December 15, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traffic splitting docs
2 participants