-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping: Kusk Services #956
Comments
Finding a way to deal with unused resources and automatically cleaning them up should be of big value regarding clunkiness of our installation. Currently we have: Absolutely necessary:
Only necessary with specific features:
Soon we'll also probably have:
The services/deployments marked in bold should only be in the cluster if the feature is in used, i.e. in the case of developer portal, it should only be there if the user adds the corresponding x-kusk policy to the OpenAPI definition. Potential solutions:
|
Solution: Currently we have this sort of setup https://github.com/kubeshop/kusk-gateway/blob/main/config/manager/service.yaml
|
Fixes #956 Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
Fixes #956 Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
Issue and Discussion ==================== See #956. Resolves #956. Summary ======= Rename `kusk-gateway-manager-service` to `kusk-gateway-manager`. Remove `kusk-gateway-validator-service` and `kusk-gateway-auth-service` since they are now part of `kusk-gateway-manager`. Changes ======= `internal/services/services.go` ------------------------------- Introduce `AuthServiceURL` and `ValidatorURL`, so we don't have to repeat service URLs in several places. `config/manager/manager.yaml` ----------------------------- Remove `command` from `containers` as we have `ENTRYPOINT ["/manager"]` in `build/manager/Dockerfile`, i.e., the block below is not needed: ```yaml - command: - /manager ``` `internal/envoy/auth/parser.go` ------------------------------- Fix possible null pointer exception when dereferencing `auth.Custom.Host.Path`. `examples/auth/oauth2/static-route/**` ------------------------------------- Remove `StaticRoute` example as `paths` is no longer applicable. `SKAFFOLD.md` ------------- Remove an item from `TODO` list section as it is no longer applicable. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
Issue and Discussion ==================== See #956. Resolves #956. Summary ======= Rename `kusk-gateway-manager-service` to `kusk-gateway-manager`. Remove `kusk-gateway-validator-service` and `kusk-gateway-auth-service` since they are now part of `kusk-gateway-manager`. Changes ======= `internal/services/services.go` ------------------------------- Introduce `AuthServiceURL` and `ValidatorURL`, so we don't have to repeat service URLs in several places. `config/manager/manager.yaml` ----------------------------- Remove `command` from `containers` as we have `ENTRYPOINT ["/manager"]` in `build/manager/Dockerfile`, i.e., the block below is not needed: ```yaml - command: - /manager ``` `internal/envoy/auth/parser.go` ------------------------------- Fix possible null pointer exception when dereferencing `auth.Custom.Host.Path`. `examples/auth/oauth2/static-route/**` ------------------------------------- Remove `StaticRoute` example as `paths` is no longer applicable. `SKAFFOLD.md` ------------- Remove an item from `TODO` list section as it is no longer applicable. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
…service (#978) * Put all kusk k8s services in one service Fixes #956 Signed-off-by: jasmingacic <jasmin.gacic@gmail.com> * Housekeeping: Kusk Services (#956) Issue and Discussion ==================== See #956. Resolves #956. Summary ======= Rename `kusk-gateway-manager-service` to `kusk-gateway-manager`. Remove `kusk-gateway-validator-service` and `kusk-gateway-auth-service` since they are now part of `kusk-gateway-manager`. Changes ======= `internal/services/services.go` ------------------------------- Introduce `AuthServiceURL` and `ValidatorURL`, so we don't have to repeat service URLs in several places. `config/manager/manager.yaml` ----------------------------- Remove `command` from `containers` as we have `ENTRYPOINT ["/manager"]` in `build/manager/Dockerfile`, i.e., the block below is not needed: ```yaml - command: - /manager ``` `internal/envoy/auth/parser.go` ------------------------------- Fix possible null pointer exception when dereferencing `auth.Custom.Host.Path`. `examples/auth/oauth2/static-route/**` ------------------------------------- Remove `StaticRoute` example as `paths` is no longer applicable. `SKAFFOLD.md` ------------- Remove an item from `TODO` list section as it is no longer applicable. --- Signed-off-by: Mohamed Bana <mohamed@bana.io> Signed-off-by: jasmingacic <jasmin.gacic@gmail.com> Signed-off-by: Mohamed Bana <mohamed@bana.io> Co-authored-by: Mohamed Bana <mohamed@bana.io>
The service created with each kusk installation should be done programmatically here.
Challenge: Since
kusk-gateway-auth-service
is only used when Cloudentity is configured we need to find a way of knowing when to remove the service if unused. Reconciler doesn't have any knowledge of the previous state of the cluster.The text was updated successfully, but these errors were encountered: