Basic Authentication - #399

Code review points part #2. See <#399> for further information.
kubeshop · Jun 15, 2022 · d789f27 · d789f27
1 parent 7dff4b3
commit d789f27
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 157 deletions.
diff --git a/pkg/options/auth.go b/pkg/options/auth.go
@@ -54,7 +54,9 @@ type AuthUpstreamHost struct {
 	Port     uint32 `json:"port,omitempty" yaml:"port,omitempty"`
 }
 
-func (o *AuthOptions) Validate() error {
+func (o AuthOptions) Validate() error {
+	// Nothing to validate yet
+	// return nil
 	return validation.ValidateStruct(&o,
 		validation.Field(&o.Scheme, validation.In("basic")),
 		validation.Field(&o.AuthUpstream.Host.Hostname, is.Host),

diff --git a/protoypes/PROTOTYPES.md b/protoypes/PROTOTYPES.md
diff --git a/protoypes/manifests/auth-basic-staticroute.yaml b/protoypes/manifests/auth-basic-staticroute.yaml
diff --git a/protoypes/manifests/ext-authz-http-service-api.yaml b/protoypes/manifests/ext-authz-http-service-api.yaml
diff --git a/protoypes/manifests/ext-authz-http-service.yaml b/protoypes/manifests/ext-authz-http-service.yaml