Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move troubleshooting out of home menu, into tasks #7128

Closed
wants to merge 1 commit into from
Closed

move troubleshooting out of home menu, into tasks #7128

wants to merge 1 commit into from

Conversation

Bradamant3
Copy link
Contributor

@Bradamant3 Bradamant3 commented Jan 29, 2018

Finally fixed branch, commit history -- this PR is per a now old-ish conversation in a user-journeys meeting, about fixing up the home page nav and finding a better home for the troubleshooting content. Probably only stage 1 in a multi-stage reorg and rewrite.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2018
@Bradamant3
Copy link
Contributor Author

/assign @chenopis @steveperry-53

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 94f3b4d

https://deploy-preview-7128--kubernetes-io-master-staging.netlify.com

@steveperry-53
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, steveperry-53

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [Bradamant3,steveperry-53]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@heckj
Copy link
Contributor

heckj commented Feb 1, 2018

/hold
Put the hold since this also appears to need a rebase, and tide/auto-bot merger is jamming up in these cases. Conflicting file: _data/docs-home.yml
@Bradamant3 feel free to remove hold once rebased, no qualms with the content

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2018
@chenopis
Copy link
Contributor

chenopis commented Feb 9, 2018

Oops. So I did create a "Troubleshooting" section under the Tasks ToC:

- title: Troubleshooting
  path: /docs/tasks/debug-application-cluster/troubleshooting/

So you will need to resolve the conflict caused by that.

@heckj heckj added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2018
@heckj
Copy link
Contributor

heckj commented Apr 12, 2018

@Bradamant3 👋 needs a rebase at a min - and otherwise wasn't sure about the /hold, but didn't want to drop it without asking you

@zacharysarah
Copy link
Contributor

@Bradamant3 👋 We've migrated the site's framework to Hugo. Please re-open this PR with changes to files in their post-migration location (/content/en/docs/...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants