Modify the terms by document style #7026

liubin · 2018-01-19T08:33:00Z

This change is

k8sio-netlify-preview-bot · 2018-01-19T08:34:43Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 94c8df1

https://deploy-preview-7026--kubernetes-io-master-staging.netlify.com

zacharysarah

Thanks for the cleanup! ✨ Kubernetes terms (Pod, Node) are capitalized but don't use code formatting.

zacharysarah · 2018-01-25T22:38:48Z

docs/concepts/services-networking/service.md

-An ExternalName service is a special case of service that does not have
-selectors. It does not define any ports or endpoints. Rather, it serves as a
+An `ExternalName` service is a special case of service that does not have
+selectors. It does not define any ports or `Endpoints`. Rather, it serves as a


No backticks needed for Endpoints.

zacharysarah · 2018-01-25T22:38:59Z

docs/concepts/services-networking/service.md

@@ -196,24 +196,24 @@ Note that in the above diagram, `clusterIP` is shown as `ServiceIP`.

 {% assign for_k8s_version="v1.9" %}{% include feature-state-beta.md %}

-In this mode, kube-proxy watches Kubernetes `services` and `endpoints`,
+In this mode, kube-proxy watches Kubernetes `Services` and `Endpoints`,


No backticks needed here.

zacharysarah · 2018-01-25T22:39:05Z

docs/concepts/services-networking/service.md

-`services` and `endpoints`  periodically, to make sure ipvs status is
-consistent with the expectation. When `service` is accessed, traffic will
-be redirected to one of the backend `pod`s.
+`Services` and `Endpoints`  periodically, to make sure ipvs status is


No backticks needed here.

zacharysarah · 2018-01-25T22:39:13Z

docs/concepts/services-networking/service.md

-consistent with the expectation. When `service` is accessed, traffic will
-be redirected to one of the backend `pod`s.
+`Services` and `Endpoints`  periodically, to make sure ipvs status is
+consistent with the expectation. When `Service` is accessed, traffic will


No backticks needed here.

zacharysarah · 2018-01-25T22:39:18Z

docs/concepts/services-networking/service.md

-be redirected to one of the backend `pod`s.
+`Services` and `Endpoints`  periodically, to make sure ipvs status is
+consistent with the expectation. When `Service` is accessed, traffic will
+be redirected to one of the backend `Pod`s.


No backticks needed here.

zacharysarah · 2018-01-25T22:39:28Z

docs/concepts/services-networking/service.md

@@ -224,11 +224,11 @@ it's not installed kube-proxy will fall back to iptables proxy mode.

 In any of proxy model, any traffic bound for the Service’s IP:Port is 
 proxied to an appropriate backend without the clients knowing anything 
-about Kubernetes or Services or Pods. Client-IP based session affinity 
-can be selected by setting service.spec.sessionAffinity to "ClientIP" 
+about Kubernetes or `Services` or `Pods`. Client-IP based session affinity 


No backticks needed here.

zacharysarah · 2018-01-25T22:39:38Z

docs/concepts/services-networking/service.md

@@ -373,7 +373,7 @@ either:
 ## Publishing services - service types

 For some parts of your application (e.g. frontends) you may want to expose a
-Service onto an external (outside of your cluster) IP address.
+`Service` onto an external (outside of your cluster) IP address.


No backticks needed here.

zacharysarah · 2018-01-25T22:39:51Z

docs/concepts/services-networking/service.md

@@ -626,7 +626,7 @@ traffic. Nodes without any pods for a particular LoadBalancer service will fail
 the NLB Target Group's health check on the auto-assigned
 `spec.healthCheckNodePort` and not recieve any traffic.

-In order to achieve even traffic, either use a DaemonSet, or specify a
+In order to achieve even traffic, either use a `DaemonSet`, or specify a


No backticks needed here.

zacharysarah · 2018-01-25T22:40:03Z

docs/concepts/services-networking/service.md

@@ -690,7 +690,7 @@ spec:
 ## Shortcomings

 Using the userspace proxy for VIPs will work at small to medium scale, but will
-not scale to very large clusters with thousands of Services.  See [the original
+not scale to very large clusters with thousands of `Services`.  See [the original


No backticks needed here.

zacharysarah · 2018-01-25T22:40:09Z

docs/concepts/services-networking/service.md

@@ -794,7 +794,7 @@ through a load-balancer, though in those cases the client IP does get altered.

 #### Ipvs

-Iptables operations slow down dramatically in large scale cluster e.g 10,000 Services. IPVS is designed for load balancing and based on in-kernel hash tables. So we can achieve performance consistency in large number of services from IPVS-based kube-proxy. Meanwhile, IPVS-based kube-proxy has more sophisticated load balancing algorithms (least conns, locality, weighted, persistence).
+Iptables operations slow down dramatically in large scale cluster e.g 10,000 `Services`. IPVS is designed for load balancing and based on in-kernel hash tables. So we can achieve performance consistency in large number of services from IPVS-based kube-proxy. Meanwhile, IPVS-based kube-proxy has more sophisticated load balancing algorithms (least conns, locality, weighted, persistence).


No backticks needed here.

zacharysarah · 2018-01-25T22:42:28Z

@liubin 👋 Please resolve the merge conflicts.

liubin · 2018-01-26T05:13:38Z

Hi @zacharysarah , thank your review and I had edited it.

zacharysarah · 2018-01-26T07:11:32Z

/lgtm

k8s-ci-robot · 2018-01-26T07:11:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liubin, zacharysarah

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~docs/concepts/services-networking/service.md/OWNERS~~ [zacharysarah]
~~docs/concepts/storage/persistent-volumes.md/OWNERS~~ [zacharysarah]
~~docs/concepts/storage/storage-classes.md/OWNERS~~ [zacharysarah]
~~docs/concepts/storage/volumes.md/OWNERS~~ [zacharysarah]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

…henopis-user-journeys * 'master' of https://github.com/kubernetes/website: (102 commits) Change deployment group (#7112) fix typos in extending doc (#7110) added installation via Powershell Gallery (#6086) Update StatefulSet API version to 1.9 for the Cassandra example (#7096) Modify the terms by document style (#7026) now that phase out in k8s/cluster/ directory, so remove relative docs (#6951) Update mysql-wordpress-persistent-volume.md (#7080) Update high-availability.md (#7086) Feature gates reference documentation (#6364) Add link to autoscaler FAQ (#7045) Replace regular characters with HTML entities. (#7038) Remove unnecessary manual node object creation (#6765) upper case restriction doesn't exist (#7003) Add an API concepts document and describe terminology and API chunking (#6540) Add kube-apiserver, kube-controller-manager, kube-scheduler and etcd to glossary. (#6600) Update what-is-kubernetes.md (#6971) Fixed the interacting with cluster section for the ubuntu installation (#6905) Update weave-network-policy.md (#6960) Added AWS eks (#6568) Update eviction strategy to include priority (#6949) ... # Conflicts: # _data/setup.yml # _data/tutorials.yml # docs/imported/release/notes.md

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2018

k8s-github-robot assigned zacharysarah Jan 19, 2018

zacharysarah suggested changes Jan 25, 2018

View reviewed changes

zacharysarah added the Docs Review: Open Issues label Jan 25, 2018

Modify the terms by document style

94c8df1

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2018

k8s-ci-robot merged commit 1a7f7a8 into kubernetes:master Jan 26, 2018

bitfield pushed a commit to bitfield/website that referenced this pull request Feb 19, 2018

Modify the terms by document style (kubernetes#7026)

0ad81bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify the terms by document style #7026

Modify the terms by document style #7026

liubin commented Jan 19, 2018 •

edited by k8s-reviewable

Loading

k8sio-netlify-preview-bot commented Jan 19, 2018 •

edited

Loading

zacharysarah left a comment

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah Jan 25, 2018

zacharysarah commented Jan 25, 2018

liubin commented Jan 26, 2018

zacharysarah commented Jan 26, 2018

k8s-ci-robot commented Jan 26, 2018

Modify the terms by document style #7026

Modify the terms by document style #7026

Conversation

liubin commented Jan 19, 2018 • edited by k8s-reviewable Loading

k8sio-netlify-preview-bot commented Jan 19, 2018 • edited Loading

zacharysarah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zacharysarah commented Jan 25, 2018

liubin commented Jan 26, 2018

zacharysarah commented Jan 26, 2018

k8s-ci-robot commented Jan 26, 2018

liubin commented Jan 19, 2018 •

edited by k8s-reviewable

Loading

k8sio-netlify-preview-bot commented Jan 19, 2018 •

edited

Loading