Use right taint key in doc #5188
Conversation
|
Deploy preview ready! Built with commit c81e811 https://deploy-preview-5188--kubernetes-io-master-staging.netlify.com |
|
Sorry my mistake, this has to be applied after kubernetes/kubernetes#51266 is in. |
|
kubernetes/kubernetes#51266 is where we are discussing deprecation. |
| @@ -101,7 +101,7 @@ when the pod is created, so it is ignored by the scheduler). Therefore: | |||
| Daemon pods do respect [taints and tolerations](/docs/concepts/configuration/assign-pod-node/#taints-and-tolerations-beta-feature), | |||
| but they are created with `NoExecute` tolerations for the following taints with no `tolerationSeconds`: | |||
|
|
|||
| - `node.alpha.kubernetes.io/notReady` | |||
| - `node.alpha.kubernetes.io/not-ready` | |||
| - `node.alpha.kubernetes.io/unreachable` | |||
| - `node.alpha.kubernetes.io/memoryPressure` | |||
There was a problem hiding this comment.
s/memoryPressure/memory-pressure
and other places.
There was a problem hiding this comment.
yes, when the time comes to fix the doc, we will need to change diskPressure, outOfDisk as well.
Also this patch has better be rebased on #5048 which is moving taint and toleration into a separate doc.
| - `node.alpha.kubernetes.io/memoryPressure` | ||
| - `node.alpha.kubernetes.io/diskPressure` | ||
| - `node.alpha.kubernetes.io/memory-pressure` | ||
| - `node.alpha.kubernetes.io/disk-pressure` |
|
@resouer Just fix the merge conflict, then this should be ready to merge once kubernetes/kubernetes#51266 is in. |
|
@chenopis Yes, I am rebasing and waiting for final review of #51266 |
13a486f to
d001a74
Compare
d001a74 to
6e7f480
Compare
|
@chenopis The code PR has been merged, please review the latest doc. |
Use right taint key in kubernetes doc
Part of: kubernetes/kubernetes#51246
DO NOT MERGE until kubernetes/kubernetes#51266 is in!This change is