Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubelet.md #48804

Closed
wants to merge 1 commit into from
Closed

Update kubelet.md #48804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/reference/command-line-tools-reference/kubelet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ kubelet [flags]
<td colspan="2">--eviction-max-pod-grace-period int32</td>
</tr>
<tr>
<td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) to use when terminating pods in response to a soft eviction threshold being met. If negative, defer to pod specified value. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td>
<td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) for terminating pods during soft eviction. A positive value sets an explicit grace period, while 0 results in immediate termination. When set to a negative value, the kubelet sends a -1 grace period to the CRI runtime, leading to immediate termination with a SIGKILL signal (exit code 137). To ensure predictable behavior, configure this parameter with a positive value or use the kubelet configuration file. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) for terminating pods during soft eviction. A positive value sets an explicit grace period, while 0 results in immediate termination. When set to a negative value, the kubelet sends a -1 grace period to the CRI runtime, leading to immediate termination with a SIGKILL signal (exit code 137). To ensure predictable behavior, configure this parameter with a positive value or use the kubelet configuration file. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td>
<td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) for terminating pods during soft eviction. A positive value sets an explicit grace period, while 0 results in immediate termination. When set to a negative value, the kubelet sends a -1 grace period to the CRI runtime, leading to immediate termination with a SIGKILL signal (exit code 137). To ensure predictable behavior, configure this parameter with a positive value in the kubelet configuration file. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is already mentioned in the note that this option should be set in the kubelet config file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that this is consistent to the output from kubelet --help.

</tr>

<tr>
Expand Down