Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap graduates to Beta1: add documentation and update feature gates #42167

Merged

Conversation

iholder101
Copy link
Contributor

Edit content/en/docs/concepts/architecture/nodes.md that's outdated.

Also, update feature gates docs to reflect that.

For more info, see: kubernetes/enhancements#4128

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jul 24, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 24, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm July 24, 2023 11:00
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 24, 2023
@netlify
Copy link

netlify bot commented Jul 24, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit b56c82c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64cbf0ef8605da0007b150d5

@sftim
Copy link
Contributor

sftim commented Jul 24, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 24, 2023
@sftim
Copy link
Contributor

sftim commented Jul 24, 2023

/sig security

@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Jul 24, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jul 24, 2023

/assign @SergeyKanzhelev
/cc

@k8s-ci-robot k8s-ci-robot requested a review from bart0sh July 24, 2023 21:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
@iholder101 iholder101 force-pushed the docs/swap-beta1-non-blog-dev128 branch from 51a6cf2 to 1de5b88 Compare August 3, 2023 16:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2023
@iholder101
Copy link
Contributor Author

/retest

Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
@iholder101 iholder101 force-pushed the docs/swap-beta1-non-blog-dev128 branch from 1de5b88 to b56c82c Compare August 3, 2023 18:24
@raesene
Copy link
Contributor

raesene commented Aug 4, 2023

Reviewed from a security perspective, LGTM

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim
Copy link
Contributor

sftim commented Aug 4, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 371ab272e655bff00c9fc6bf6b436381c64386f2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit d8ab063 into kubernetes:dev-1.28 Aug 4, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
…on-blog-dev128

Swap graduates to Beta1: add documentation and update feature gates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/security Categorizes an issue or PR as relevant to SIG Security. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants