Add docs for CloudDualStackNodeIPs docs (KEP-3705) #40188
Conversation
|
/sig network |
There was a problem hiding this comment.
I'd frame it slightly differently.
AIUI, --node-ip is always a comma-separated list, but there are special considerations for the on-a-cloud-provider-and-dual-stack case.
Also, we should emphasize more that in the most common case, you can actually omit it entirely.
|
Why is this not giving me a preview? That seemed to happen automatically on past docs PRs... |
ac0bdb9 to
2b49259
Compare
|
/retitle Add docs for CloudDualStackNodeIPs docs (KEP-3705) Looks like the Netlify integration is broken. |
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
2b49259 to
09008fd
Compare
|
LGTM for docs. Does this need a tech review? I think I'd prefer one. |
|
BTW you can get a Netlify preview if you force-push a slightly different commit / set of commits. |
/assign @aojea
eh, I figured out how to be non-lazy and build the docs locally 🙂. Mostly I wanted to make sure that the added "feature-state" bit looked right in context, and it does. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 621535754968da054511cd44dbd6f880f82eb293
|
|
@kubernetes/sig-network-pr-reviews : PTAL and provide a tech signoff. Once done, we shall be ready for merge! |
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label tide/merge-method-squash |
Co-authored-by: Tim Bannister <tim@scalefactory.com>
09008fd to
5f1c6de
Compare
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
/hold cancel |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 42d3808f52de9b2f6f84c0749642b5c83a83d2a8
|
While trying to figure out where to document this, I noticed that we document single-stack
--node-ipin the node docs, and dual-stack--node-iponly in the dual-stack docs. Given the existing docs, it seemed to make the most sense to add the cloud dual-stack note to the dual-stack docs, but I also added a link from the node docs. (I did this as a separate commit since it makes sense independently of the KEP-3705 documentation, but feel free to squash.)Might need better explanation of enabling the feature gate?